From mboxrd@z Thu Jan 1 00:00:00 1970 From: vinod.koul@intel.com (Vinod Koul) Date: Wed, 1 Apr 2015 09:10:44 +0530 Subject: [PATCH] dmaengine: ste_dma40: fix implicit conversion In-Reply-To: <1426981868-1988-1-git-send-email-stefan@agner.ch> References: <1426981868-1988-1-git-send-email-stefan@agner.ch> Message-ID: <20150401034044.GT7192@intel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sun, Mar 22, 2015 at 12:51:08AM +0100, Stefan Agner wrote: > The function d40_prep_sg takes the type enum dma_transfer_direction > as second last parameter. However, the memcpy calls pass DMA_NONE > which is of type enum dma_data_direction. Fix this by passing the > actual transfer direction DMA_MEM_TO_MEM. > > This does not change the actual code flow since only the transfer > direction DMA_MEM_TO_DEV and DMA_DEV_TO_MEM are actually used in the > function d40_prep_sg. Applied, now -- ~Vinod From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752838AbbDADp0 (ORCPT ); Tue, 31 Mar 2015 23:45:26 -0400 Received: from mga02.intel.com ([134.134.136.20]:60863 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751644AbbDADpW (ORCPT ); Tue, 31 Mar 2015 23:45:22 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,503,1422950400"; d="scan'208";a="549302748" Date: Wed, 1 Apr 2015 09:10:44 +0530 From: Vinod Koul To: Stefan Agner Cc: linus.walleij@linaro.org, dan.j.williams@intel.com, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, llvmlinux@lists.linuxfoundation.org Subject: Re: [PATCH] dmaengine: ste_dma40: fix implicit conversion Message-ID: <20150401034044.GT7192@intel.com> References: <1426981868-1988-1-git-send-email-stefan@agner.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426981868-1988-1-git-send-email-stefan@agner.ch> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 22, 2015 at 12:51:08AM +0100, Stefan Agner wrote: > The function d40_prep_sg takes the type enum dma_transfer_direction > as second last parameter. However, the memcpy calls pass DMA_NONE > which is of type enum dma_data_direction. Fix this by passing the > actual transfer direction DMA_MEM_TO_MEM. > > This does not change the actual code flow since only the transfer > direction DMA_MEM_TO_DEV and DMA_DEV_TO_MEM are actually used in the > function d40_prep_sg. Applied, now -- ~Vinod