From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zabrina.hetzner-de.towertech.it (zabrina.hetzner-de.towertech.it. [178.63.16.19]) by gmr-mx.google.com with ESMTP id i8si60856wif.1.2015.04.01.00.05.22 for ; Wed, 01 Apr 2015 00:05:22 -0700 (PDT) Date: Wed, 1 Apr 2015 09:05:20 +0200 From: Alessandro Zummo To: Joe Perches Cc: Alexandre Belloni , Aaro Koskinen , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [rtc-linux] Re: [PATCH 3/3] rtc: hctosys: use function name in the error log Message-ID: <20150401090520.559ead39@linux.lan.towertech.it> In-Reply-To: <1427858308.18175.30.camel@perches.com> References: <1427576976-22353-1-git-send-email-aaro.koskinen@iki.fi> <1427576976-22353-3-git-send-email-aaro.koskinen@iki.fi> <20150401030124.GO3849@piout.net> <1427858308.18175.30.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On Tue, 31 Mar 2015 20:18:28 -0700 Joe Perches wrote: > Neither __func__ or __FILE__ is really useful here. > The message is already specific enough without it. > > If anything, it'd probably be better to add > > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt Seems reasonable given that pr_fmt is widely used elsewhere. I don't like too much the need to have one define for each file, but it's the way it works :-/ -- Best regards, Alessandro Zummo - CEO, Tower Technologies - Torino, Italy http://www.towertech.it -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752845AbbDAHF4 (ORCPT ); Wed, 1 Apr 2015 03:05:56 -0400 Received: from zabrina.hetzner-de.towertech.it ([178.63.16.19]:56402 "EHLO zabrina.hetzner-de.towertech.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752655AbbDAHFZ (ORCPT ); Wed, 1 Apr 2015 03:05:25 -0400 Date: Wed, 1 Apr 2015 09:05:20 +0200 From: Alessandro Zummo To: Joe Perches Cc: Alexandre Belloni , Aaro Koskinen , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [rtc-linux] Re: [PATCH 3/3] rtc: hctosys: use function name in the error log Message-ID: <20150401090520.559ead39@linux.lan.towertech.it> In-Reply-To: <1427858308.18175.30.camel@perches.com> References: <1427576976-22353-1-git-send-email-aaro.koskinen@iki.fi> <1427576976-22353-3-git-send-email-aaro.koskinen@iki.fi> <20150401030124.GO3849@piout.net> <1427858308.18175.30.camel@perches.com> Organization: Tower Technologies MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 31 Mar 2015 20:18:28 -0700 Joe Perches wrote: > Neither __func__ or __FILE__ is really useful here. > The message is already specific enough without it. > > If anything, it'd probably be better to add > > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt Seems reasonable given that pr_fmt is widely used elsewhere. I don't like too much the need to have one define for each file, but it's the way it works :-/ -- Best regards, Alessandro Zummo - CEO, Tower Technologies - Torino, Italy http://www.towertech.it