From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59180)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berto@igalia.com>) id 1YdFXv-0007XU-Su
	for qemu-devel@nongnu.org; Wed, 01 Apr 2015 06:06:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berto@igalia.com>) id 1YdFXr-0003MP-Jm
	for qemu-devel@nongnu.org; Wed, 01 Apr 2015 06:06:51 -0400
Received: from smtp3.mundo-r.com ([212.51.32.191]:56728 helo=smtp4.mundo-r.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berto@igalia.com>) id 1YdFXr-00037Y-D3
	for qemu-devel@nongnu.org; Wed, 01 Apr 2015 06:06:47 -0400
Date: Wed, 1 Apr 2015 12:06:08 +0200
From: Alberto Garcia <berto@igalia.com>
Message-ID: <20150401100608.GA13383@igalia.com>
References: <cover.1427732020.git.berto@igalia.com>
	<3e2f5bedd4889507e5083faf431250a814205db9.1427732020.git.berto@igalia.com>
	<20150401095940.GB2777@fam-t430.nay.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150401095940.GB2777@fam-t430.nay.redhat.com>
Subject: Re: [Qemu-devel] [PATCH 6/7] throttle: add the name of the
 ThrottleGroup to BlockDeviceInfo
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

On Wed, Apr 01, 2015 at 05:59:40PM +0800, Fam Zheng wrote:

> >          info->has_iops_size = cfg.op_size;
> >          info->iops_size = cfg.op_size;
> > +
> > +        info->has_group = true;
> > +        info->group = g_strdup(throttle_group_get_name(bs));
> 
> True even if it's unset?

Note that that's inside an "if (bs->io_limits_enabled)" block.

io_limits_enabled is set immediately after adding a BDS to a
throttling group, and that requires a name.

> > +# @group: #optional throttle group name (Since 2.3)
> 
> Will probably be 2.4.

Right.

Berto