From: Jiri Olsa <jolsa@redhat.com>
To: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>,
namhyung@kernel.org, Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH perf/core 2/2] perf-probe: Check the orphaned -x option
Date: Wed, 1 Apr 2015 13:11:04 +0200 [thread overview]
Message-ID: <20150401111104.GA1326@krava> (raw)
In-Reply-To: <20150401102541.17137.75477.stgit@localhost.localdomain>
On Wed, Apr 01, 2015 at 07:25:42PM +0900, Masami Hiramatsu wrote:
> To avoid probing in unintended binary, the orphaned -x option
> must be checked and warned.
>
> Without this patch, following command sets up the probe in
> the kernel.
> -----
> # perf probe -a strcpy -x ./perf
> Added new event:
> probe:strcpy (on strcpy)
>
> You can now use it in all perf tools, such as:
>
> perf record -e probe:strcpy -aR sleep 1
> -----
>
> But in this case, it seems that the user may want to probe
> in the perf binary. With this patch, perf-probe correctly
> handles the orphaned -x.
> -----
> # perf probe -a strcpy -x ./perf
> Error: -x/-m must follow the probe definitions.
> ...
> -----
>
> Reported-by: Jiri Olsa <jolsa@redhat.com>
works nicely, thanks a lot!
Tested-by: Jiri Olsa <jolsa@kernel.org>
jirka
next prev parent reply other threads:[~2015-04-01 11:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 17:46 [RFC] perf probe: -x option position issue Jiri Olsa
2015-03-30 19:48 ` Arnaldo Carvalho de Melo
2015-03-31 8:04 ` Masami Hiramatsu
2015-03-31 13:33 ` Arnaldo Carvalho de Melo
2015-04-01 8:37 ` Masami Hiramatsu
2015-04-01 10:25 ` [PATCH perf/core 1/2] perf-probe: Support multiple probes on different binaries Masami Hiramatsu
2015-04-11 6:37 ` [tip:perf/core] perf probe: " tip-bot for Masami Hiramatsu
2015-04-01 10:25 ` [PATCH perf/core 2/2] perf-probe: Check the orphaned -x option Masami Hiramatsu
2015-04-01 11:11 ` Jiri Olsa [this message]
2015-04-10 6:51 ` Masami Hiramatsu
2015-04-10 13:22 ` Arnaldo Carvalho de Melo
2015-04-11 6:38 ` [tip:perf/core] perf probe: " tip-bot for Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150401111104.GA1326@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=dsahern@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.