From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.rutland@arm.com (Mark Rutland) Date: Wed, 1 Apr 2015 12:48:32 +0100 Subject: [PATCH 2/8] doc/bindings: Update PCIe devicetree binding documentation for LS2085A In-Reply-To: <1427888463-29549-3-git-send-email-bhupesh.sharma@freescale.com> References: <1427888463-29549-1-git-send-email-bhupesh.sharma@freescale.com> <1427888463-29549-3-git-send-email-bhupesh.sharma@freescale.com> Message-ID: <20150401114832.GD11403@leverpostej> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On Wed, Apr 01, 2015 at 12:40:56PM +0100, Bhupesh Sharma wrote: > Add the documentation for compatible string "fsl,ls2085a-pcie" > for LS2085A platform. > > Signed-off-by: Minghuan Lian [...] > Change-Id: I0d51607e86544be8906c996c08a2b2b558243bd4 > Reviewed-on: http://git.am.freescale.net:8181/28740 > Tested-by: Review Code-CDREVIEW These three are meaningless here. Please drop them. > Reviewed-by: Bhupesh Sharma > Tested-by: Bhupesh Sharma > --- > .../devicetree/bindings/pci/layerscape-pci.txt | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/pci/layerscape-pci.txt b/Documentation/devicetree/bindings/pci/layerscape-pci.txt > index 6286f04..0654809 100644 > --- a/Documentation/devicetree/bindings/pci/layerscape-pci.txt > +++ b/Documentation/devicetree/bindings/pci/layerscape-pci.txt > @@ -4,7 +4,8 @@ This PCIe host controller is based on the Synopsis Designware PCIe IP > and thus inherits all the common properties defined in designware-pcie.txt. > > Required properties: > -- compatible: should contain the platform identifier such as "fsl,ls1021a-pcie" > +- compatible: should contain the platform identifier such as "fsl,ls1021a-pcie", > + "fsl,ls2085a-pcie". Please format this as a list, e.g. - compatible: schould contain one of: * "fsl,ls1021a-pcie" * "fsl,ls2085a-pcie" Is the ls2085a PCIe controller significantly different from that of ls1021a? Is "fsl,ls1021a-pcie" valid as a fallback entry? Mark. > - reg: base addresses and lengths of the PCIe controller > - interrupts: A list of interrupt outputs of the controller. Must contain an > entry for each entry in the interrupt-names property. > -- > 1.7.9.5 > >