From: Daniel Vetter <daniel@ffwll.ch>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Allow legacy interface for legacy Y tiled display
Date: Wed, 1 Apr 2015 14:20:53 +0200 [thread overview]
Message-ID: <20150401122053.GD6354@phenom.ffwll.local> (raw)
In-Reply-To: <1427882025-28421-1-git-send-email-tvrtko.ursulin@linux.intel.com>
On Wed, Apr 01, 2015 at 10:53:45AM +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Makes it easier for userspace to start supporting Y tiled display,
> for at least the legacy format.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
For the record: The point here is that we'll get a user for fb modifiers
by enabling Y tiling, not enabling Y tiling itself ... On that goal this
patch falls short, so nacked.
-Daniel
> ---
> drivers/gpu/drm/i915/intel_display.c | 15 ++++++++++++---
> 1 file changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 1813190..de50631 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -13347,10 +13347,19 @@ static int intel_framebuffer_init(struct drm_device *dev,
> return -EINVAL;
> }
> } else {
> - if (obj->tiling_mode == I915_TILING_X)
> + switch (obj->tiling_mode) {
> + case I915_TILING_NONE:
> + mode_cmd->modifier[0] = DRM_FORMAT_MOD_NONE;
> + break;
> + case I915_TILING_X:
> mode_cmd->modifier[0] = I915_FORMAT_MOD_X_TILED;
> - else if (obj->tiling_mode == I915_TILING_Y) {
> - DRM_DEBUG("No Y tiling for legacy addfb\n");
> + break;
> + case I915_TILING_Y:
> + mode_cmd->modifier[0] = I915_FORMAT_MOD_Y_TILED;
> + break;
> + default:
> + DRM_DEBUG("Unsupported fb obj tiling %u!\n",
> + obj->tiling_mode);
> return -EINVAL;
> }
> }
> --
> 2.3.2
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-04-01 12:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-01 9:53 [PATCH] drm/i915: Allow legacy interface for legacy Y tiled display Tvrtko Ursulin
2015-04-01 12:20 ` Daniel Vetter [this message]
2015-04-01 12:28 ` Chris Wilson
2015-04-01 14:45 ` Jesse Barnes
2015-04-02 12:31 ` shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150401122053.GD6354@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=daniel.vetter@ffwll.ch \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.