All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Wang Nan <wangnan0@huawei.com>
Cc: acme@kernel.org, jolsa@kernel.org, namhyung@kernel.org,
	mingo@redhat.com, lizefan@huawei.com, pi3orama@163.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf: unwind: fix segbase for libunwind.
Date: Wed, 1 Apr 2015 16:48:39 +0200	[thread overview]
Message-ID: <20150401144839.GA17340@gmail.com> (raw)
In-Reply-To: <1427897332-145581-1-git-send-email-wangnan0@huawei.com>


* Wang Nan <wangnan0@huawei.com> wrote:

> Perf passes incorrect segbase and table_data to libunwind when 
> map->pgoff != 0, causes unwind failure. This patch fixes this 
> problem.
> 
> segbase is an absolute offset from the head of object file, directly 
> read from ELF file. Original code computes corresponding virtual 
> address using map->start + segbase, doesn't consider map->pgoff. 
> Which causes libunwind read from incorrect offset.

What's the effect of this bug in practice?

Is there any before/after output you can show that demonstrates the 
fix?

Thanks,

	Ingo

  reply	other threads:[~2015-04-01 14:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-01 14:08 [PATCH] perf: unwind: fix segbase for libunwind Wang Nan
2015-04-01 14:48 ` Ingo Molnar [this message]
2015-04-02  5:07   ` Wang Nan
2015-04-02  5:19     ` Wang Nan
2015-04-02  8:11       ` Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150401144839.GA17340@gmail.com \
    --to=mingo@kernel.org \
    --cc=acme@kernel.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=pi3orama@163.com \
    --cc=wangnan0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.