All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Charlie Wong Super <1213charlie@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] Staging: comedi: addi_apci_1564: Delete whitespace
Date: Wed, 1 Apr 2015 17:19:20 +0200	[thread overview]
Message-ID: <20150401151920.GA578@kroah.com> (raw)
In-Reply-To: <20150330154011.GA11201@ThinkPad>

On Mon, Mar 30, 2015 at 11:40:11PM +0800, Charlie Wong Super wrote:
> This patch fixes the checkpatch.pl warning:
> WARNING: line over 80 characters
> FILE: drivers/staging/comedi/drivers/addi_apci_1564.c:114:
> +	unsigned int ctrl;		/* interrupt mode OR (edge) . AND (level) */
> 
> Signed-off-by: Charlie Wong Super <1213charlie@gmail.com>
> ---
>  drivers/staging/comedi/drivers/addi_apci_1564.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/addi_apci_1564.c b/drivers/staging/comedi/drivers/addi_apci_1564.c
> index c481c48..dd335e8 100644
> --- a/drivers/staging/comedi/drivers/addi_apci_1564.c
> +++ b/drivers/staging/comedi/drivers/addi_apci_1564.c
> @@ -106,12 +106,12 @@
>  #define APCI1564_COUNTER(x)			((x) * 0x20)
>  
>  struct apci1564_private {
> -	unsigned long eeprom;		/* base address of EEPROM register */
> -	unsigned long timer;		/* base address of 12-bit timer */
> -	unsigned long counters;		/* base address of 32-bit counters */
> -	unsigned int mode1;		/* riding-edge/high level channels */
> -	unsigned int mode2;		/* falling-edge/low level channels */
> -	unsigned int ctrl;		/* interrupt mode OR (edge) . AND (level) */
> +	unsigned long eeprom;		/*base address of EEPROM register*/
> +	unsigned long timer;		/*base address of 12-bit timer*/
> +	unsigned long counters;		/*base address of 32-bit counters*/
> +	unsigned int mode1;		/*riding-edge/high level channels*/
> +	unsigned int mode2;		/*falling-edge/low level channels*/
> +	unsigned int ctrl;		/*interrupt mode OR (edge).AND(level)*/

That makes things look worse :(


      parent reply	other threads:[~2015-04-01 15:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-30 15:40 [PATCH] Staging: comedi: addi_apci_1564: Delete whitespace Charlie Wong Super
2015-03-30 15:42 ` [Outreachy kernel] " Julia Lawall
2015-03-31  5:10   ` Charlie WONG Super
2015-03-31  5:20   ` Charlie WONG Super
2015-04-01 15:19 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150401151920.GA578@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=1213charlie@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.