From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH v2 4/4] Add virtio-vga bits.
Date: Wed, 1 Apr 2015 15:26:26 +0200
Message-ID: <20150401152535-mutt-send-email-mst@redhat.com>
References: <1427894130-14228-1-git-send-email-kraxel@redhat.com>
 <1427894130-14228-5-git-send-email-kraxel@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by gabe.freedesktop.org (Postfix) with ESMTP id C36A26E113
 for <dri-devel@lists.freedesktop.org>; Wed,  1 Apr 2015 06:26:33 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1427894130-14228-5-git-send-email-kraxel@redhat.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: virtio-dev@lists.oasis-open.org, Rusty Russell <rusty@rustcorp.com.au>, open list <linux-kernel@vger.kernel.org>, dri-devel@lists.freedesktop.org, "open list:VIRTIO CORE, NET..." <virtualization@lists.linux-foundation.org>, airlied@redhat.com
List-Id: dri-devel@lists.freedesktop.org

T24gV2VkLCBBcHIgMDEsIDIwMTUgYXQgMDM6MTU6MzBQTSArMDIwMCwgR2VyZCBIb2ZmbWFubiB3
cm90ZToKPiArc3RhdGljIHZvaWQgdmlydGlvX3BjaV9raWNrX291dF9maXJtd2FyZV9mYihzdHJ1
Y3QgcGNpX2RldiAqcGNpX2RldikKPiArewo+ICsJc3RydWN0IGFwZXJ0dXJlc19zdHJ1Y3QgKmFw
Owo+ICsJYm9vbCBwcmltYXJ5Owo+ICsKPiArCWFwID0gYWxsb2NfYXBlcnR1cmVzKDEpOwo+ICsJ
aWYgKCFhcCkKPiArCQlyZXR1cm47Cj4gKwo+ICsJYXAtPnJhbmdlc1swXS5iYXNlID0gcGNpX3Jl
c291cmNlX3N0YXJ0KHBjaV9kZXYsIDIpOwo+ICsJYXAtPnJhbmdlc1swXS5zaXplID0gcGNpX3Jl
c291cmNlX2xlbihwY2lfZGV2LCAyKTsKCkkgdGhvdWdodCB5b3UgbWVudGlvbmVkIGl0J3MgYmV0
dGVyIHRvIHN3aXRjaCB0byBhIGRpZmZlcmVudCBCQVIKdG8gYmUgY29tcGF0aWJsZSB3aXRoIHN0
ZHZnYT8KCi0tIApNU1QKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Au
b3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2
ZWwK

From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753295AbbDAN0k (ORCPT <rfc822;w@1wt.eu>);
	Wed, 1 Apr 2015 09:26:40 -0400
Received: from mx1.redhat.com ([209.132.183.28]:41523 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752083AbbDAN0i (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 1 Apr 2015 09:26:38 -0400
Date: Wed, 1 Apr 2015 15:26:26 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: dri-devel@lists.freedesktop.org, virtio-dev@lists.oasis-open.org,
        airlied@gmail.com, airlied@redhat.com, David Airlie <airlied@linux.ie>,
        Rusty Russell <rusty@rustcorp.com.au>,
        open list <linux-kernel@vger.kernel.org>,
        "open list:VIRTIO CORE, NET..." 
	<virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH v2 4/4] Add virtio-vga bits.
Message-ID: <20150401152535-mutt-send-email-mst@redhat.com>
References: <1427894130-14228-1-git-send-email-kraxel@redhat.com>
 <1427894130-14228-5-git-send-email-kraxel@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1427894130-14228-5-git-send-email-kraxel@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Apr 01, 2015 at 03:15:30PM +0200, Gerd Hoffmann wrote:
> +static void virtio_pci_kick_out_firmware_fb(struct pci_dev *pci_dev)
> +{
> +	struct apertures_struct *ap;
> +	bool primary;
> +
> +	ap = alloc_apertures(1);
> +	if (!ap)
> +		return;
> +
> +	ap->ranges[0].base = pci_resource_start(pci_dev, 2);
> +	ap->ranges[0].size = pci_resource_len(pci_dev, 2);

I thought you mentioned it's better to switch to a different BAR
to be compatible with stdvga?

-- 
MST