Re: [PATCH 2/2] x86/domctl: Don't allow a toolstack domain to pause itself

[Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>]

On Wed, Apr 01, 2015 at 04:31:03PM +0100, Andrew Cooper wrote:
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: Keir Fraser <keir@xen.org>
> CC: Jan Beulich <JBeulich@suse.com>

Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> ---
>  xen/arch/x86/domctl.c |   12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c
> index bcbdf95..ff3b423 100644
> --- a/xen/arch/x86/domctl.c
> +++ b/xen/arch/x86/domctl.c
> @@ -411,7 +411,8 @@ long arch_do_domctl(
>          struct hvm_domain_context c = { .size = domctl->u.hvmcontext.size };
>  
>          ret = -EINVAL;
> -        if ( !is_hvm_domain(d) )
> +        if ( (d == currd) || /* no domain_pause() */
> +             !is_hvm_domain(d) )
>              goto sethvmcontext_out;
>  
>          ret = -ENOMEM;
> @@ -436,7 +437,8 @@ long arch_do_domctl(
>          struct hvm_domain_context c = { 0 };
>  
>          ret = -EINVAL;
> -        if ( !is_hvm_domain(d) )
> +        if ( (d == currd) || /* no domain_pause() */
> +             !is_hvm_domain(d) )
>              goto gethvmcontext_out;
>  
>          c.size = hvm_save_size(d);
> @@ -475,7 +477,8 @@ long arch_do_domctl(
>  
>      case XEN_DOMCTL_gethvmcontext_partial:
>          ret = -EINVAL;
> -        if ( !is_hvm_domain(d) )
> +        if ( (d == currd) || /* no domain_pause() */
> +             !is_hvm_domain(d) )
>              break;
>  
>          domain_pause(d);
> @@ -896,7 +899,8 @@ long arch_do_domctl(
>              break;
>  
>          ret = -EINVAL;
> -        if ( !is_hvm_domain(d))
> +        if ( (v == curr) || /* no vcpu_pause() */
> +             !is_hvm_domain(d) )
>              break;
>  
>          ret = hvm_debug_op(v, domctl->u.debug_op.op);
> -- 
> 1.7.10.4
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel