From: Jerome Glisse <j.glisse@gmail.com>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: Jerome Glisse <jglisse@redhat.com>,
ML dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH libdrm 02/24] radeon: remove empty function declarations
Date: Wed, 1 Apr 2015 17:26:26 -0400 [thread overview]
Message-ID: <20150401212624.GB6606@gmail.com> (raw)
In-Reply-To: <CACvgo527zeUfYz4n55vQ-vVaZqY196Rox2K+roq=ftrrJ6yc8w@mail.gmail.com>
On Wed, Apr 01, 2015 at 09:57:40PM +0100, Emil Velikov wrote:
> On 1 April 2015 at 21:34, Emil Velikov <emil.l.velikov@gmail.com> wrote:
> > On 1 April 2015 at 18:30, Jerome Glisse <j.glisse@gmail.com> wrote:
> >> On Wed, Apr 01, 2015 at 05:15:13PM +0100, Emil Velikov wrote:
> >>> Missing definition and unused since their introduction.
> >>>
> >>> Cc: Jerome Glisse <jglisse@redhat.com>
> >>> Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
> >>
> >> NAK
> >>
> >> I use all this in tools to debug lockup. Best course of action is to
> >> exclude bof.h from being distributed. My tools static link and i just
> >> point them to libdrm git tree.
> >>
> > Did not notice any mention of such out-of-tree tools in the commit
> > that introduced these functions, so I've naively assumed that they are
> > unused.
> Scratch that - I'm blind.
>
> Upon closer look at your radeondb repo, I cannot see any static
> linking in there. Also it seems that some of the functionality is
> duplicated between the two. With the radeondb version being out of
> date :'(
Yeah i guess i never pushed anywhere patches that did that, divergence btw
my memory and what is out there. All this symbol can just be hidden and
never exported. It would cleaner, but i still need the bof.h intact as i
tend to just cp it afaict into my local radeondb copy so that i am in
sync with libdrm code.
Cheers,
Jérôme
>
> -Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-04-01 21:26 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-01 16:15 [PATCH libdrm 00/24] Annotate private symbols, drop drm_public macro Emil Velikov
2015-04-01 16:15 ` [PATCH libdrm 01/24] configure.ac: split -fvisibility and __attribute__((visibility)) checks Emil Velikov
2015-04-08 0:18 ` Alan Coopersmith
2015-04-01 16:15 ` [PATCH libdrm 02/24] radeon: remove empty function declarations Emil Velikov
2015-04-01 17:30 ` Jerome Glisse
2015-04-01 20:34 ` Emil Velikov
2015-04-01 20:57 ` Emil Velikov
2015-04-01 21:26 ` Jerome Glisse [this message]
2015-04-01 22:04 ` Emil Velikov
2015-04-02 3:51 ` Jerome Glisse
2015-04-01 21:24 ` Jerome Glisse
2015-04-01 16:15 ` [PATCH libdrm 03/24] radeon: remove unused functions Emil Velikov
2015-04-01 17:31 ` Jerome Glisse
2015-04-01 16:15 ` [PATCH libdrm 04/24] radeon: annotate bof_incref, bof_string functions as static Emil Velikov
2015-04-01 17:31 ` Jerome Glisse
2015-04-01 17:32 ` Jerome Glisse
2015-04-01 16:15 ` [PATCH libdrm 05/24] radeon: remove more unused functions Emil Velikov
2015-04-01 17:32 ` Jerome Glisse
2015-04-01 16:15 ` [PATCH libdrm 06/24] radeon: remove no-longer used static functions Emil Velikov
2015-04-01 16:15 ` [PATCH libdrm 07/24] radeon: annotate the private symbols Emil Velikov
2015-04-02 2:48 ` Michel Dänzer
2015-04-02 3:57 ` Jerome Glisse
2015-04-02 23:10 ` Emil Velikov
2015-04-05 15:29 ` [PATCH libdrm v2 02/19] radeon: move bof.[ch] out of libdrm_radeon Emil Velikov
2015-04-01 16:15 ` [PATCH libdrm 08/24] radeon: add symbols test Emil Velikov
2015-04-01 16:15 ` [PATCH libdrm 09/24] freedreno: annotate the private symbols Emil Velikov
2015-04-01 16:15 ` [PATCH libdrm 10/24] freedreno: add symbols test Emil Velikov
2015-04-01 16:15 ` [PATCH libdrm 11/24] intel: remove the drm_mm* symbol workarounds Emil Velikov
2015-04-09 14:56 ` Emil Velikov
2015-04-10 6:05 ` Eric Anholt
2015-04-10 17:40 ` Emil Velikov
2015-04-01 16:15 ` [PATCH libdrm 12/24] intel: remove unused mmFindBlock Emil Velikov
2015-04-01 16:15 ` [PATCH libdrm 13/24] intel: annotate the private symbols Emil Velikov
2015-04-01 16:15 ` [PATCH libdrm 14/24] intel: add symbols test Emil Velikov
2015-04-01 16:15 ` [PATCH libdrm 15/24] nouveau: annotate the private symbols Emil Velikov
2015-04-01 16:15 ` [PATCH libdrm 16/24] nouveau: add symbols test Emil Velikov
2015-04-01 16:15 ` [PATCH libdrm 17/24] libkms: annotate private symbols Emil Velikov
2015-04-01 16:15 ` [PATCH libdrm 18/24] libkms: add symbols test Emil Velikov
2015-04-01 16:15 ` [PATCH libdrm 19/24] exynos: " Emil Velikov
2015-04-01 16:15 ` [PATCH libdrm 20/24] omap: " Emil Velikov
2015-04-01 16:15 ` [PATCH libdrm 21/24] tegra: " Emil Velikov
2015-04-01 16:15 ` [PATCH libdrm 22/24] drm: rename libdrm{,_macros}.h Emil Velikov
2015-04-01 16:15 ` [PATCH libdrm 23/24] drm: remove no longer needed VISIBILITY_CFLAGS Emil Velikov
2015-04-01 16:15 ` [PATCH libdrm 24/24] drm: remove drm_public macro Emil Velikov
2015-04-21 15:41 ` [PATCH libdrm 00/24] Annotate private symbols, drop " Emil Velikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150401212624.GB6606@gmail.com \
--to=j.glisse@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=jglisse@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.