From: Borislav Petkov <bp@alien8.de>
To: Ingo Molnar <mingo@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Kees Cook <keescook@chromium.org>, x86-ml <x86@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v1.1] x86/mm/ASLR: Propagate ASLR status to kernel proper
Date: Thu, 2 Apr 2015 13:19:15 +0200 [thread overview]
Message-ID: <20150402111915.GC3483@pd.tnic> (raw)
In-Reply-To: <20150402110713.GA29311@gmail.com>
On Thu, Apr 02, 2015 at 01:07:13PM +0200, Ingo Molnar wrote:
> So doesn't a 'nokaslr' boot option still make sense, to be able to
> debug KASLR failures and such?
That's still parsed in arch/x86/boot/compressed/aslr.c
> > + if (kaslr_enabled())
> > + pr_emerg("Kernel Offset: 0x%lx from 0x%lx (relocation range: 0x%lx-0x%lx)\n",
> > + (unsigned long)&_text - __START_KERNEL,
> > + __START_KERNEL,
> > + __START_KERNEL_map,
> > + MODULES_VADDR-1);
> > + else
> > + pr_emerg("Kernel Offset: disabled\n");
>
> Nit: curly braces for multi-line statements and so.
I guess by multi-line you mean multiple source lines...
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
next prev parent reply other threads:[~2015-04-02 11:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-01 10:59 [PATCH] x86/mm/ASLR: Propagate ASLR status to kernel proper Borislav Petkov
2015-04-02 4:03 ` [PATCH v1.1] " Borislav Petkov
2015-04-02 11:07 ` Ingo Molnar
2015-04-02 11:19 ` Borislav Petkov [this message]
2015-04-02 11:29 ` Ingo Molnar
2015-04-02 11:50 ` Borislav Petkov
2015-04-13 23:18 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150402111915.GC3483@pd.tnic \
--to=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.