From: Ralf Baechle <ralf@linux-mips.org>
To: Huacai Chen <chenhc@lemote.com>
Cc: "Steven J. Hill" <Steven.Hill@imgtec.com>,
linux-mips@linux-mips.org, Fuxin Zhang <zhangfx@lemote.com>,
Zhangjin Wu <wuzhangjin@gmail.com>
Subject: Re: [PATCH V9 6/7] MIPS: Loongson-3: Add chipset ACPI platform driver
Date: Thu, 2 Apr 2015 14:46:28 +0200 [thread overview]
Message-ID: <20150402124628.GD20157@linux-mips.org> (raw)
In-Reply-To: <1427597650-2368-7-git-send-email-chenhc@lemote.com>
On Sun, Mar 29, 2015 at 10:54:10AM +0800, Huacai Chen wrote:
> arch/mips/loongson/common/pci.c | 6 ++
> drivers/platform/mips/Makefile | 3 +
> drivers/platform/mips/acpi_init.c | 150 +++++++++++++++++++++++++++++++++++++
Applied - but:
This isn't even a proper driver but rather a collection of subroutines.
I wonder this has to reside in drivers/platform/mips, not in drivers/acpi/
or even in the Loongson arch code?
> diff --git a/drivers/platform/mips/Makefile b/drivers/platform/mips/Makefile
> index 8dfd039..522c8e1 100644
> --- a/drivers/platform/mips/Makefile
> +++ b/drivers/platform/mips/Makefile
> @@ -1 +1,4 @@
> +ifdef CONFIG_CPU_LOONGSON3
> +obj-y += acpi_init.o
> obj-$(CONFIG_CPU_HWMON) += cpu_hwmon.o
> +endif
This is where the yelling starts. A Makefile that doesn't define any
obj-* or lib-* variables such as this one if CONFIG_CPU_LOONGSON3 is
undefined, will break the build. In other words, this hasn't been tested
on even a single other platform. I've fixed this but it's normally
up to the submitter to ensure this sort of thing doesn't happen.
Ralf
next prev parent reply other threads:[~2015-04-02 12:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-29 2:54 [PATCH V9 0/7] MIPS: Loongson-3: Improve kernel functionality Huacai Chen
2015-03-29 2:54 ` [PATCH V9 1/7] MIPS: Hibernate: flush TLB entries earlier Huacai Chen
2015-03-29 2:54 ` Huacai Chen
2015-03-29 2:54 ` [PATCH V9 2/7] MIPS: Hibernate: Restructure files and functions Huacai Chen
2015-03-29 2:54 ` [PATCH V9 3/7] MIPS: Loongson: Introduce and use cpu_has_coherent_cache feature Huacai Chen
2015-03-29 2:54 ` [PATCH V9 4/7] MIPS: perf: Add hardware perf events support for Loongson-3 Huacai Chen
2015-03-29 2:54 ` [PATCH V9 5/7] MIPS: Loongson-3: Add CPU Hwmon platform driver Huacai Chen
2015-03-29 2:54 ` [PATCH V9 6/7] MIPS: Loongson-3: Add chipset ACPI " Huacai Chen
2015-04-02 12:46 ` Ralf Baechle [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-04-02 13:15 =?gb18030?B?s8K7qrLF?=
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150402124628.GD20157@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=Steven.Hill@imgtec.com \
--cc=chenhc@lemote.com \
--cc=linux-mips@linux-mips.org \
--cc=wuzhangjin@gmail.com \
--cc=zhangfx@lemote.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.