Re: implementing a classic Xen front/back pv driver pair to provide a transport for 9P FS Protocol

[Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>]

On Wed, Apr 01, 2015 at 07:36:49PM -0600, Linda wrote:
> First, Julien, your suggestion worked like a charm.
> So here's what's happened tonight.  I tried to build the tools directory of
> my git repository.  Although I used the sudo command in my virtual ubuntu, I
> got a permission denied error  126 on xen_foreign.

One way to help with that is if you do:

make 1>&2 2>log

And attach the log.
> 
> Second, I tried to follow the protocol for submitting my patches.  I changed
> libxl_utils.c and libxl_utils.h, in my repository, add and commit them.
> Unfortunately, I didn't include my signature (next page of instructions I
> was following), and couldn't figure how to get back in to add them.

git commit --amend

Or if you want to do more of them:

git rebase -i origin/staging

(and in the editor change 'pick' to 'r').

> 
> Finally, I tried git send-email (took a bit to find I had to install it).
> Now it doesn't like the format of my send-email:

Again, please copy-n-paste the command line you had.

>  to the devlopers list above and cc'ing Julien and Wei, followed by:
> 1.  following this with the files (even with --no-format-patch), error was
> "no subject line"
> 2.  (different attempt) the repository "master"  error complained about the
> format patch

Not sure I understand that. Is that for 'git send-email' or 'git
format-patch'?
> 
> SO   if anyone is up at an ungodly hour and can explain any of these errors
> to me (I'm in Colorado - so it's 7:30 here), especially with a fix, I'd be
> grateful.  Otherwise, Julien, Wei, I'll start at about 7am my time, maybe a
> little earlier.

The previous OPW had an article about using git and how to do it with
kernel patches. It is exactly the same flow - except different email
address.

Anyhow, what I end up doing is:

1). git format-patch --subject-prefix "PATCH RFC" origin/staging..

(which generates 0001-, 0002-, etc files - for two patches).

2). git send-email --to xen-devel@xenproject.org --to someotheremail.org
--compose --subject "[PATCH RFC] Patches to fix XYZ." 000*.patch

And in the editor do a little writeup of what the patches have.
At the end of this, I attach the output from:

git diff --stat origin/staging..

git shortlog origin/staging..

which gives a nice diff output and what the patches are.

And then send it off.
> 
> Thanks.
> 
> Linda Jacobson
> 
> On 4/1/2015 2:57 PM, Julien Grall wrote:
> >
> >
> >On 01/04/2015 18:46, Linda wrote:
> >>I'll try it.  That's the
> >>
> >>libvncserver-dev libsdl-dev libjpeg62-dev
> >>
> >>Should I keep the libsdl-dev?
> >>
> >>   In the meantime, I'm following the git protocol for patches. I
> >>successfully cloned xen.git.  The next statement in the directions - I
> >>can't tell if it's one statement on many lines, or many statements.  It
> >>starts out git branch -a
> >>When I type this alone, I get "Not a git repository"  When I type in the
> >>many lines as a single command I get the error message:
> >>origin/master no such file or directory
> >
> >You have to type the command "git branch -a"  in the git repository (i.e
> >the directory xen.git).
> >
> >
> >>
> >>This comes from the line remotes/origin/HEAD->origin
> >>
> >>?????
> >
> >This is normal. The line starting by '$' is a command. Everything else is
> >an example output of the execution of the command.
> >
> >Obviously, you have to drop the '$' when typing copying the command.
> >
> >To go further, '$' means a command to execute with your current user and
> >'#' a command to execute with root privileges (i.e adding sudo before).
> >
> >This is usually a standard on Linux/BSD shell documentation.
> >
> >Although, there is some place within this wiki page where the command
> >doesn't have '$'/'#' (see [1]). So you to judge yourself if the line looks
> >like a command or not :).
> >
> >Regards,
> >
> >[1] http://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches#Git_send-email
> >
> >
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel