All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RESEND] [PATCH] fastboot: Proper download gadget unregister and clear when cable is missing
Date: Thu, 2 Apr 2015 19:11:14 +0200	[thread overview]
Message-ID: <201504021911.14524.marex@denx.de> (raw)
In-Reply-To: <20150330100613.0675b647@amdc2363>

On Monday, March 30, 2015 at 10:06:13 AM, Lukasz Majewski wrote:
> Hi Paul,
> 
> > Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> > ---
> > 
> >  common/cmd_fastboot.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/common/cmd_fastboot.c b/common/cmd_fastboot.c
> > index 346ab80..7956a5b 100644
> > --- a/common/cmd_fastboot.c
> > +++ b/common/cmd_fastboot.c
> > @@ -23,6 +23,8 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag,
> > int argc, char *const argv[]) if (!g_dnl_board_usb_cable_connected())
> > { puts("\rUSB cable not detected.\n" \
> > 
> >  		     "Command exit.\n");
> > 
> > +		g_dnl_unregister();
> > +		g_dnl_clear_detach();
> > 
> >  		return CMD_RET_FAILURE;
> >  	
> >  	}
> 
> This is just a minor comment - in your future patches please add some
> commit message even for this very short patch.
> 
> Despite that,
> 
> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
> 
> If other (Marek, Tom) don't mind I will take this through -dfu tree.

Please do, thanks!

btw. is this for current or next release ?

Best regards,
Marek Vasut

  parent reply	other threads:[~2015-04-02 17:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-28 17:22 [U-Boot] [RESEND] [PATCH] fastboot: Proper download gadget unregister and clear when cable is missing Paul Kocialkowski
2015-03-30  8:06 ` Lukasz Majewski
2015-03-30 13:28   ` Paul Kocialkowski
2015-04-02 17:11   ` Marek Vasut [this message]
2015-04-03  7:35     ` Lukasz Majewski
2015-04-03  8:09       ` Marek Vasut
2015-04-08  9:01 ` Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201504021911.14524.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.