From: Theodore Ts'o <tytso@mit.edu>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext4: fix transposition typo in format string
Date: Thu, 2 Apr 2015 16:47:48 -0400 [thread overview]
Message-ID: <20150402204748.GC450@thunk.org> (raw)
In-Reply-To: <1424441495-32581-1-git-send-email-linux@rasmusvillemoes.dk>
On Fri, Feb 20, 2015 at 03:11:35PM +0100, Rasmus Villemoes wrote:
> According to C99, %*.s means the same as %*.0s, in other words, print
> as many spaces as the field width argument says and effectively ignore
> the string argument. That is certainly not what was meant here. The
> kernel's printf implementation, however, treats it as if the . was not
> there, i.e. as %*s. I don't know if de->name is nul-terminated or not,
> but in any case I'm guessing the intention was to use de->name_len as
> precision instead of field width.
Applied, sorry for the delay.
(Note: the code is explicitly #ifdef'ed out so the only way the bug
would show up is if a developer explicitly modified the source to
#define INLINE_DIR_DEBUG, so it's not -stable material.)
- Ted
prev parent reply other threads:[~2015-04-02 20:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-20 14:11 [PATCH] ext4: fix transposition typo in format string Rasmus Villemoes
2015-03-02 9:55 ` Rasmus Villemoes
2015-04-02 20:47 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150402204748.GC450@thunk.org \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.