From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Jann Horn <jann@thejh.net>
Subject: Re: [PATCH] push --signed: tighten what the receiving end can ask to sign
Date: Thu, 2 Apr 2015 18:16:03 -0400 [thread overview]
Message-ID: <20150402221603.GA13077@peff.net> (raw)
In-Reply-To: <xmqqlhiagp2s.fsf@gitster.dls.corp.google.com>
On Thu, Apr 02, 2015 at 03:09:15PM -0700, Junio C Hamano wrote:
> + if (isalnum(ch) ||
> + ch == '-' || ch == '.' ||
> + ch == '/' || ch == '+' ||
> + ch == '=' || ch == '_')
> + continue;
I think this looks good. Earlier I suggested reducing the set of
allowable punctuation characters, but if we want to allow base64, that's
"+/=" right there. We use "-" ourselves, leaving only "." and "_" as
possible extras. But both of those are as useful as "-" for separators,
and are fairly innocuous, so I don't mind leaving them.
-Peff
prev parent reply other threads:[~2015-04-02 22:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-02 22:09 [PATCH] push --signed: tighten what the receiving end can ask to sign Junio C Hamano
2015-04-02 22:16 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150402221603.GA13077@peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jann@thejh.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.