From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "usb: host/sl811-hcd: fix sparse warning"
Date: Fri, 3 Apr 2015 15:44:46 +0200 [thread overview]
Message-ID: <20150403134446.GA10645@kroah.com> (raw)
In-Reply-To: <1427973341-1019-1-git-send-email-sudipm.mukherjee@gmail.com>
On Thu, Apr 02, 2015 at 04:45:40PM +0530, Sudip Mukherjee wrote:
> This reverts commit <1dc6120ef7f003305d99ef12f598a6b05eacc38c>.
>
> if we are doing allyesconfig on x86_64, build fails with error:
> drivers/built-in.o: In function `sl811_cs_probe':
> sl811_cs.c:(.text+0x1d4612e): undefined reference to `sl811h_driver'
>
> this commit has declared sl811h_driver as static but it was being
> accessed from sl811_cs.c.
>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
> drivers/usb/host/sl811-hcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Someone else sent this patch in a few days before you did, sorry.
greg k-h
prev parent reply other threads:[~2015-04-03 13:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-02 11:15 [PATCH] Revert "usb: host/sl811-hcd: fix sparse warning" Sudip Mukherjee
2015-04-03 13:44 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150403134446.GA10645@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=prabhakar.csengg@gmail.com \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.