From: Paul Mackerras <paulus@samba.org>
To: Marc Branchaud <marcnarc@xiplink.com>
Cc: git@vger.kernel.org
Subject: Re: [RFC PATCH 2/2] gitk: Show the rev(s) the user specified on the command line in the window title.
Date: Mon, 6 Apr 2015 14:37:11 +1000 [thread overview]
Message-ID: <20150406043711.GC31463@iris.ozlabs.ibm.com> (raw)
In-Reply-To: <1420566720-25238-3-git-send-email-marcnarc@xiplink.com>
On Tue, Jan 06, 2015 at 12:52:00PM -0500, Marc Branchaud wrote:
> Signed-off-by: Marc Branchaud <marcnarc@xiplink.com>
> ---
>
> I often open multiple gitk windows in the same working directory to examine
> other branches or refs in the repo. This change allows me to distinguish
> which window is showing what.
>
> This is an RFC because it doesn't behave great with views. I don't use views
> at all, so this doesn't bother me. I'm not too sure what should be displayed
> if the user changes views -- probably the view name, but I'm not sure how to
> get a that in the code.
The view name is in $viewname($curview). If that is "Command line"
you probably want to show some selected command line arguments.
Using $vrevs($curview) seems about right, though it will contain
"--gitk-symmetric-diff-marker" in some situations, which is an
internal thing that we don't want to show externally. You should
probably filter it out.
The patch will need a proper description before I can apply it, of
course.
Paul.
next prev parent reply other threads:[~2015-04-06 4:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-06 17:51 [PATCH 0/2] Tweaking the gitk window title Marc Branchaud
2015-01-06 17:51 ` [PATCH 1/2] gitk: Rearrange window title to be more conventional Marc Branchaud
2015-01-06 17:52 ` [RFC PATCH 2/2] gitk: Show the rev(s) the user specified on the command line in the window title Marc Branchaud
2015-04-06 4:37 ` Paul Mackerras [this message]
2015-04-07 15:51 ` [PATCHv2] gitk: Show the current view's name " Marc Branchaud
2015-05-04 14:26 ` Marc Branchaud
2015-05-17 1:39 ` Paul Mackerras
2015-01-26 14:58 ` [PATCH 0/2] Tweaking the gitk " Marc Branchaud
2015-03-02 15:39 ` Marc Branchaud
2015-03-23 14:18 ` [PATCH 1/2] gitk: Rearrange window title to be more conventional Marc Branchaud
2015-03-23 14:18 ` [PATCH 2/2] gitk: Show the rev(s) the user specified on the command line in the window title Marc Branchaud
2015-04-06 4:38 ` [PATCH 1/2] gitk: Rearrange window title to be more conventional Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150406043711.GC31463@iris.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=git@vger.kernel.org \
--cc=marcnarc@xiplink.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.