From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: IIO <linux-iio@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Lee Jones <lee.jones@linaro.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Hartmut Knaack <knaack.h@gmx.de>, Aaron Lu <aaron.lu@intel.com>,
Todd Brandt <todd.e.brandt@linux.intel.com>
Subject: Re: [PATCH] iio/axp288_adc: add missing channel info mask
Date: Mon, 6 Apr 2015 11:39:50 -0700 [thread overview]
Message-ID: <20150406113950.3ebfa694@icelake> (raw)
In-Reply-To: <550D5EE7.20208@kernel.org>
On Sat, 21 Mar 2015 12:07:03 +0000
Jonathan Cameron <jic23@kernel.org> wrote:
> > - .info_mask_separate = BIT(IIO_CHAN_INFO_PROCESSED),
> > + .info_mask_separate = BIT(IIO_CHAN_INFO_PROCESSED)
> > + | BIT(IIO_CHAN_INFO_RAW),
> > },
> These cases strike me as problematic. You should not need both. If
> the consumer is reading _raw from a channel that only supplies
> PROCESSED then that is the bug, not the lack of support for a raw
> read.
> > };
Very sorry about the delay, you are right that we should just need RAW.
V2 patch just sent.
Thanks,
Jacob
prev parent reply other threads:[~2015-04-06 18:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-16 17:34 [PATCH] iio/axp288_adc: add missing channel info mask Jacob Pan
2015-03-21 12:07 ` Jonathan Cameron
2015-04-06 18:39 ` Jacob Pan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150406113950.3ebfa694@icelake \
--to=jacob.jun.pan@linux.intel.com \
--cc=aaron.lu@intel.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=todd.e.brandt@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.