From: Alex Suykov <alex.suykov@gmail.com>
To: Sven Eckelmann <sven@narfation.org>
Cc: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] musl build fixes
Date: Mon, 6 Apr 2015 17:27:58 +0300 [thread overview]
Message-ID: <20150406142758.GA16243@vostro> (raw)
In-Reply-To: <4593170.BoRA6mpdPI@sven-edge>
Thu, Apr 02, 2015 at 08:39:32AM +0200, Sven Eckelmann wrote:
> > Moving linux/types.h to packet.h does make sense I think.
> > However, it also brings linux/if_ether.h there, which immediately
> > makes musl support difficult. Maybe even impractical.
>
> The maintainers rejected the use of __KERNEL__ checks when Markus Pargmann
> wanted to use them [1]. So I may have to modify my patch to move bitops and
> if_ether.h back to main.h. Maybe you can try to modify your packet.h as seen
> in the new version of "[PATCHv3 2/4] batman-adv: Add required to includes to
> all files" which I will send in some minutes. Would be nice when this version
> + your linux/if_ether.h -> netinet/if_ether.h would work with musl.
Not only it works, it also turns out to be shortest musl-fixes patch so far.
With linux/types.h in packet.h, I only need to replace linux/if_ether.h
with netinet/if_ether.h to get a successful musl build.
prev parent reply other threads:[~2015-04-06 14:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-01 17:18 [B.A.T.M.A.N.] musl build fixes Alex Suykov
2015-04-01 17:36 ` Sven Eckelmann
2015-04-01 19:35 ` Alex Suykov
2015-04-01 20:02 ` Sven Eckelmann
2015-04-01 21:53 ` Alex Suykov
2015-04-02 6:39 ` Sven Eckelmann
2015-04-06 14:27 ` Alex Suykov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150406142758.GA16243@vostro \
--to=alex.suykov@gmail.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=sven@narfation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.