All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] usb: hub: allow pgood_delay to be specified via env
Date: Mon, 6 Apr 2015 16:58:11 +0200	[thread overview]
Message-ID: <201504061658.11313.marex@denx.de> (raw)
In-Reply-To: <1428329107-2294-1-git-send-email-tharvey@gateworks.com>

On Monday, April 06, 2015 at 04:05:07 PM, Tim Harvey wrote:
> Some USB devices break the spec and require longer warm-up times. Allow
> the usb_pgood_delay env variable to override the calculated time.
> 
> I have encountered this specficically with several different sized/branded
> USB sticks with VID:PID 058f:6387 (Alcor Micro Corp. Transcend JetFlash)
> where I need to set usb_pgood_delay to 2000ms to make them detectable.
> 
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>

Hi!

this looks like a good idea. I have a hint for improvement -- in case you
get a timeout waiting for the device to be detected, maybe the error message
should mention that you can try setting this env variable and try again ?

Best regards,
Marek Vasut

  reply	other threads:[~2015-04-06 14:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-06 14:05 [U-Boot] [PATCH] usb: hub: allow pgood_delay to be specified via env Tim Harvey
2015-04-06 14:58 ` Marek Vasut [this message]
2015-04-07 14:52   ` Tim Harvey
2015-04-07 15:34     ` Stephen Warren
2015-04-07 16:04       ` Tim Harvey
2015-04-07 18:55         ` Marek Vasut
2015-04-08 16:50           ` Tim Harvey
2015-04-08 19:21             ` [U-Boot] [PATCH v2] " Tim Harvey
2015-04-11 16:59               ` Marek Vasut
2015-04-11 17:08               ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201504061658.11313.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.