All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matt Fleming <matt@codeblueprint.co.uk>
To: Ross Lagerwall <ross.lagerwall@citrix.com>
Cc: linux-efi@vger.kernel.org,
	Matthew Garrett <matthew.garrett@nebula.com>,
	Jeremy Kerr <jk@ozlabs.org>,
	Matt Fleming <matt.fleming@intel.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] efivarfs: Ensure VariableName is NUL-terminated
Date: Mon, 6 Apr 2015 19:39:49 +0100	[thread overview]
Message-ID: <20150406183949.GA7511@codeblueprint.co.uk> (raw)
In-Reply-To: <1427960340-5339-1-git-send-email-ross.lagerwall@citrix.com>

On Thu, 02 Apr, at 08:39:00AM, Ross Lagerwall wrote:
> Some buggy firmware implementations update VariableNameSize on success
> such that it does not include the final NUL character which results in
> garbage in the efivarfs name entries.  Use kzalloc on the efivar_entry
> (as is done in efivars.c) to ensure that the name is always
> NUL-terminated.
> 
> The buggy firmware is:
> BIOS Information
>         Vendor: Intel Corp.
>         Version: S1200RP.86B.02.02.0005.102320140911
>         Release Date: 10/23/2014
>         BIOS Revision: 4.6
> System Information
>         Manufacturer: Intel Corporation
>         Product Name: S1200RP_SE
> 
> Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
> ---
>  fs/efivarfs/super.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, applied with Matthew's ACK!

-- 
Matt Fleming, Intel Open Source Technology Center

      parent reply	other threads:[~2015-04-06 18:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-02  7:39 [PATCH RESEND] efivarfs: Ensure VariableName is NUL-terminated Ross Lagerwall
2015-04-02  7:39 ` Ross Lagerwall
     [not found] ` <1427960340-5339-1-git-send-email-ross.lagerwall-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org>
2015-04-02 18:28   ` Matthew Garrett
2015-04-02 18:28     ` Matthew Garrett
2015-04-06 18:39 ` Matt Fleming [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150406183949.GA7511@codeblueprint.co.uk \
    --to=matt@codeblueprint.co.uk \
    --cc=jk@ozlabs.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt.fleming@intel.com \
    --cc=matthew.garrett@nebula.com \
    --cc=ross.lagerwall@citrix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.