From: "J. Bruce Fields" <bfields@fieldses.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Kinglong Mee <kinglongmee@gmail.com>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] nfsd: clear NFSEXP_PNFS flags if not supports pnfs in kernel
Date: Mon, 6 Apr 2015 15:51:54 -0400 [thread overview]
Message-ID: <20150406195154.GC3363@fieldses.org> (raw)
In-Reply-To: <20150406120247.GB13634@infradead.org>
On Mon, Apr 06, 2015 at 05:02:47AM -0700, Christoph Hellwig wrote:
> On Sun, Apr 05, 2015 at 11:13:27PM +0800, Kinglong Mee wrote:
> > nfsd should not show "pnfs" flag in proc file if the filesystem
> > does not support pnfs.
>
> Hmm, do we want to silently clear or reject it? Either way the
> !CONFIG_NFSD_PNFS stub needs to do the same.
There's a note:
/* quietly ignore unknown words and anything
* following. Newer user-space can try to set
* new values, then see what the result was.
*/
Not sure if that's the best approach, but I guess we should stick with
it.
--b.
prev parent reply other threads:[~2015-04-06 19:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-05 15:13 [PATCH] nfsd: clear NFSEXP_PNFS flags if not supports pnfs in kernel Kinglong Mee
2015-04-06 12:02 ` Christoph Hellwig
2015-04-06 19:51 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150406195154.GC3363@fieldses.org \
--to=bfields@fieldses.org \
--cc=hch@infradead.org \
--cc=kinglongmee@gmail.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.