From: Steffen Klassert <steffen.klassert@secunet.com>
To: Romain Francoise <romain@orebokech.com>
Cc: Alexey Dobriyan <adobriyan@gmail.com>, <davem@davemloft.net>,
<mike@normi.net>, <netdev@vger.kernel.org>,
<herbert@gondor.apana.org.au>
Subject: Re: [PATCH] xfrm: fix xfrm_input/xfrm_tunnel_check oops
Date: Tue, 7 Apr 2015 14:32:57 +0200 [thread overview]
Message-ID: <20150407123256.GA8928@secunet.com> (raw)
In-Reply-To: <877ftoi18s.fsf@orebokech.com>
On Tue, Apr 07, 2015 at 02:14:43PM +0200, Romain Francoise wrote:
> On Tue, Apr 07, 2015 at 02:43:41PM +0300, Alexey Dobriyan wrote:
> > On Tue, Apr 07, 2015 at 10:57:32AM +0200, Steffen Klassert wrote:
> >> On Thu, Apr 02, 2015 at 10:58:24AM +0300, Alexey Dobriyan wrote:
> >> > https://bugzilla.kernel.org/show_bug.cgi?id=95211
> >> >
> >> > Commit 70be6c91c86596ad2b60c73587880b47df170a41
> >> > ("xfrm: Add xfrm_tunnel_skb_cb to the skb common buffer") added check
> >> > which dereferences ->outer_mode too early but larval SAs don't have
> >> > this pointer set (yet). So check for tunnel stuff later.
> >> >
> >> > Mike Noordermeer reported this bug and patiently applied all the debugging.
> >> >
> >> > Technically this is remote-oops-in-interrupt-context type of thing.
> >> >
> >> > BUG: unable to handle kernel NULL pointer dereference at 0000000000000034
> >> > IP: [<ffffffff8150dca2>] xfrm_input+0x3c2/0x5a0
> >> > ...
> >> > [<ffffffff81500fc6>] ? xfrm4_esp_rcv+0x36/0x70
> >> > [<ffffffff814acc9a>] ? ip_local_deliver_finish+0x9a/0x200
> >> > [<ffffffff81471b83>] ? __netif_receive_skb_core+0x6f3/0x8f0
> >> > ...
> >> >
> >> > RIP [<ffffffff8150dca2>] xfrm_input+0x3c2/0x5a0
> >> > Kernel panic - not syncing: Fatal exception in interrupt
> >> >
> >> > Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> >>
> >> Good catch!
> >>
> >> Applied to the ipsec tree, thanks everyone!
>
> > For the record Mike confirmed that the patch works:
> > https://bugzilla.kernel.org/show_bug.cgi?id=95211#c20
>
> Does this only affect configurations that use VTI? It's not clear from
> the description.
xfrm_tunnel_check() dereferences outer_mode only if it finds a tunnel
pointer, so it affects only vti SAs.
prev parent reply other threads:[~2015-04-07 12:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-02 7:58 [PATCH] xfrm: fix xfrm_input/xfrm_tunnel_check oops Alexey Dobriyan
2015-04-07 8:57 ` Steffen Klassert
2015-04-07 11:43 ` Alexey Dobriyan
2015-04-07 12:14 ` Romain Francoise
2015-04-07 12:32 ` Steffen Klassert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150407123256.GA8928@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=adobriyan@gmail.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=mike@normi.net \
--cc=netdev@vger.kernel.org \
--cc=romain@orebokech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.