From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45372) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YfSul-0005oa-IC for qemu-devel@nongnu.org; Tue, 07 Apr 2015 08:47:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YfSuh-0005B9-IB for qemu-devel@nongnu.org; Tue, 07 Apr 2015 08:47:35 -0400 Received: from smtp3.mundo-r.com ([212.51.32.191]:51461 helo=smtp4.mundo-r.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YfSuh-00056N-Ba for qemu-devel@nongnu.org; Tue, 07 Apr 2015 08:47:31 -0400 Date: Tue, 7 Apr 2015 14:46:51 +0200 From: Alberto Garcia Message-ID: <20150407124651.GA30085@igalia.com> References: <1428003106-20754-1-git-send-email-eblake@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1428003106-20754-1-git-send-email-eblake@redhat.com> Subject: Re: [Qemu-devel] [PATCH] qapi: Accept 'null' in QMP List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, armbru@redhat.com, akong@redhat.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com On Thu, Apr 02, 2015 at 01:31:46PM -0600, Eric Blake wrote: > So instead, this patch creates a new QObject subtype: QNull. The code looks good, but Markus's approach of using a single instance seems probably a bit better for this case. > --- /dev/null > +++ b/include/qapi/qmp/qnull.h > @@ -0,0 +1,23 @@ > +/* > + * QBool Module You probably meant QNull here. Berto