Re: [PATCH] staging: panel: remove duplicate code

[Willy Tarreau <w@1wt.eu>]

On Tue, Apr 07, 2015 at 12:12:06PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Apr 07, 2015 at 03:26:58PM +0530, Sudip Mukherjee wrote:
> > On Tue, Apr 07, 2015 at 11:44:29AM +0200, Greg Kroah-Hartman wrote:
> > > On Tue, Apr 07, 2015 at 02:55:02PM +0530, Sudip Mukherjee wrote:
> > > > On Tue, Apr 07, 2015 at 11:49:30AM +0300, Dan Carpenter wrote:
> > > > > On Tue, Apr 07, 2015 at 01:55:01PM +0530, Sudip Mukherjee wrote:
> > > > > 
> > > > > I hadn't looked at this driver much before.  It sucks that
> > > > > parport_driver ->attach() functions can't fail... 
> > > > 
> > > > then maybe, we can change the code of parport. currently attach and
> > > > parport_register_driver never fails. we can modify it so that if attach
> > > > fails then parport_register_driver will also fail. will not be that much
> > > > difficult as it has been used only in 13 places.
> > > > your views ?
> > > > 
> > > > and since we are discussing parallel ports, few days back i saw one
> > > > post in ubuntuforums that his scanner is not working because of
> > > > lack of ppscsi.I mailed Tim Waugh, but he is not interested to work
> > > > with ppscsi anymore. parallel port scanners are almost a thing of the past
> > > > now. do you think it is worth that i pick up the code and modify
> > > > it for our latest kernel and submit to Greg ?
> > > 
> > > If you have some parport hardware, and want to take it on, that would be
> > > great.  The code needs a maintainer, and the apis are _really_ old and
> > > messy, as you have found out.
> > what kind of parport hardware will you suggest?
> 
> No idea, go look at the drivers and code to figure that out.

Not-so-old laptops used to have parport connectors for a while, and can be
found at a very cheap price or even for free by now with dead batteries.
I've been using mine as a JTAG connector exclusively until I replaced this
laptop.

A number of old mini-itx boards used to have a parallell port and were easy
to hack on (eg: those with a jack power connector, onboard video and a PXE
capable NIC to boot the freshly built kernel over the network). They're less
easy to find though.

If you want to run on your PC, you'll have to order a PCIe parallel port NIC
I guess.

Cheers,
Willy