From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH v4 19/19] IB/mad: Implement Intel Omni-Path Architecture MAD processing Date: Tue, 7 Apr 2015 11:19:20 -0600 Message-ID: <20150407171920.GB15634@obsidianresearch.com> References: <1423092585-26692-1-git-send-email-ira.weiny@intel.com> <1423092585-26692-20-git-send-email-ira.weiny@intel.com> <1828884A29C6694DAF28B7E6B8A82373A8FBD9DE@ORSMSX109.amr.corp.intel.com> <20150407022954.GA7531@obsidianresearch.com> <1828884A29C6694DAF28B7E6B8A82373A8FBE17D@ORSMSX109.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1828884A29C6694DAF28B7E6B8A82373A8FBE17D-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Hefty, Sean" Cc: "Weiny, Ira" , "roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org" List-Id: linux-rdma@vger.kernel.org On Tue, Apr 07, 2015 at 05:15:07PM +0000, Hefty, Sean wrote: > IMO, a MAD should be self-identifying. E.g. update the mad private > structure to indicate what sort of MAD it is -- is_smp(), is_gmp(), > is_rmpp(), is_opa(), is_ib(), much like the device checks are being > updated. decording into the mad private structure during initial validation seems like a good idea. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html