All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Taeung Song <treeze.taeung@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
	linux-kernel@vger.kernel.org, namhyung@kernel.org
Subject: Re: [PATCH 1/2] perf tools: Add 'perf-config' command
Date: Tue, 7 Apr 2015 19:57:09 +0200	[thread overview]
Message-ID: <20150407175709.GA25980@krava.redhat.com> (raw)
In-Reply-To: <1428169288-8482-1-git-send-email-treeze.taeung@gmail.com>

On Sun, Apr 05, 2015 at 02:41:27AM +0900, Taeung Song wrote:

SNIP

> +	"perf config [options]",
> +	NULL
> +};
> +static const struct option config_options[] = {
> +	OPT_BOOLEAN('l', "list", &params.list_action, "list up current configurations"),
> +	OPT_END()
> +};
> +
> +static void check_argc(int argc, int min, int max)

seems like all callers have min == max, so there's no need for 2 params

jirka

  parent reply	other threads:[~2015-04-07 17:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-04 17:41 [PATCH 1/2] perf tools: Add 'perf-config' command Taeung Song
2015-04-04 17:41 ` [PATCH 2/2] perf tools: Add options 'get', 'set' and 'unset' to 'perf-config' Taeung Song
2015-04-07 18:06   ` Jiri Olsa
2015-04-07 17:57 ` Jiri Olsa [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-04-09 14:26 [PATCH 1/2] perf tools: Add 'perf-config' command Taeung Song
2015-04-09 15:57 ` Arnaldo Carvalho de Melo
2015-04-10  8:53 ` Jiri Olsa
2015-04-12 14:44 Taeung Song
2015-04-13  6:16 ` Namhyung Kim
     [not found]   ` <5CB87CAF-B6EE-4AE0-BC3C-45CEF14C28EC@gmail.com>
2015-04-19  3:27     ` Namhyung Kim
     [not found]   ` <70EA4387-5059-4026-8819-039474865EEE@gmail.com>
2015-04-19  3:34     ` Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150407175709.GA25980@krava.redhat.com \
    --to=jolsa@redhat.com \
    --cc=acme@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namhyung@kernel.org \
    --cc=treeze.taeung@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.