Re: [meta-oe][PATCH] bluez collection: add (moved from oe-core)

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 3134 bytes --]

On Wed, Apr 08, 2015 at 11:05:57AM +0000, Iorga, Cristian wrote:
> Hi Martin,
> 
> I have to ask...
> The patches (applying to bluez package) that are part of this submission, also needs to be changed to a 4 spaces tab?

No, only the metadata (.bbclass, .bb, .inc, .conf) files are using 4
spaces, patches should follow whatever convention the component is
using.

> I do agree on the others, I am not sure if it would be ok to alter the original patches.
> Also, I did not know the difference in policies of OE versus oe-core, sorry, my fault.

See http://www.openembedded.org/wiki/Styleguide

Cheers,

> -----Original Message-----
> From: openembedded-devel-bounces@lists.openembedded.org [mailto:openembedded-devel-bounces@lists.openembedded.org] On Behalf Of Martin Jansa
> Sent: Tuesday, April 7, 2015 1:57 PM
> To: openembedded-devel@lists.openembedded.org
> Subject: Re: [oe] [meta-oe][PATCH] bluez collection: add (moved from oe-core)
> 
> On Mon, Apr 06, 2015 at 07:21:49AM +0000, Iorga, Cristian wrote:
> > No, I intended to place it exactly where it is in the patch.
> 
> Then improve the commit message and fix indentation (use 4 spaces instead of tabs).
> 
> > -----Original Message-----
> > From: openembedded-devel-bounces@lists.openembedded.org 
> > [mailto:openembedded-devel-bounces@lists.openembedded.org] On Behalf 
> > Of Martin Jansa
> > Sent: Friday, April 3, 2015 8:45 PM
> > To: openembedded-devel@lists.openembedded.org
> > Subject: Re: [oe] [meta-oe][PATCH] bluez collection: add (moved from 
> > oe-core)
> > 
> > On Fri, Apr 03, 2015 at 05:16:48PM +0300, Cristian Iorga wrote:
> > > BlueZ 4.x Bluetooth stack has been removed from oe-core.
> > > However, it is still supported, so add it to meta-oe networking layer.
> > 
> > "meta-oe netwrorking layer" is very confusing, did you plan to put it in meta-networking?
> > 
> > > In order to use it in oe-core/poky/YP 'bluez4' needs to be added to 
> > > distro features. 'bluetooth' distro feature needs to be present also.
> > > 
> > > Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
> > > ---
> > >  .../obsolete_automake_macros.patch                 | 14 +++++++
> > >  .../bluez/bluez-hcidump_2.5.bb                     | 22 +++++++++++
> > >  .../bluez/bluez4-4.101/bluetooth.conf              | 16 ++++++++
> > >  .../bluez/bluez4-4.101/fix-udev-paths.patch        | 37 +++++++++++++++++
> > >  .../bluez/bluez4-4.101/install-test-script.patch   | 26 ++++++++++++
> > >  ...ork-fix-network-Connect-method-parameters.patch | 30 ++++++++++++++
> > >  .../bluez4-4.101/obsolete_automake_macros.patch    | 14 +++++++
> > >  .../bluez/bluez4-4.101/sbc_mmx.patch               | 24 +++++++++++
> > >  ...pygobject-instead-ofgobject-introspection.patch | 27 +++++++++++++
> > >  meta-oe/recipes-connectivity/bluez/bluez4.inc      | 46 ++++++++++++++++++++++
> > >  meta-oe/recipes-connectivity/bluez/bluez4_4.101.bb | 46 ++++++++++++++++++++++
> > >  .../bluez/gst-plugin-bluetooth_4.101.bb            | 39 ++++++++++++++++++

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]