diff for duplicates of <20150408122251.GJ10964@mwanda> diff --git a/a/1.txt b/N1/1.txt index 3f9fac8..3fbb583 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -4,15 +4,15 @@ On Wed, Apr 08, 2015 at 01:51:08PM +0200, walter harms wrote: > Am 08.04.2015 11:51, schrieb Julia Lawall: > >> void ext4_fname_crypto_free_buffer(void **buf) > >> { -> >> - if (*buf = NULL || IS_ERR(buf)) -> >> + if (*buf = NULL || IS_ERR(*buf)) +> >> - if (*buf == NULL || IS_ERR(buf)) +> >> + if (*buf == NULL || IS_ERR(*buf)) > > > > Why not use IS_ERR_OR_NULL? > > > > julia > > -> why test *buf = NULL ? xfree() can handle this. +> why test *buf == NULL ? xfree() can handle this. > > the question is do programm depend on *buf=NULL. > In case of IS_ERR(*buf) *buf will be left unchanged diff --git a/a/content_digest b/N1/content_digest index fffa3bc..9f9d6a7 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\05525162C.3020808@bfs.de\0" "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Subject\0Re: [patch] ext4 crypto: testing the wrong variable\0" - "Date\0Wed, 08 Apr 2015 12:22:51 +0000\0" + "Date\0Wed, 8 Apr 2015 15:22:51 +0300\0" "To\0walter harms <wharms@bfs.de>\0" "Cc\0Julia Lawall <julia.lawall@lip6.fr>" Theodore Ts'o <tytso@mit.edu> @@ -19,15 +19,15 @@ "> Am 08.04.2015 11:51, schrieb Julia Lawall:\n" "> >> void ext4_fname_crypto_free_buffer(void **buf)\n" "> >> {\n" - "> >> -\tif (*buf = NULL || IS_ERR(buf))\n" - "> >> +\tif (*buf = NULL || IS_ERR(*buf))\n" + "> >> -\tif (*buf == NULL || IS_ERR(buf))\n" + "> >> +\tif (*buf == NULL || IS_ERR(*buf))\n" "> > \n" "> > Why not use IS_ERR_OR_NULL?\n" "> > \n" "> > julia\n" "> \n" "> \n" - "> why test *buf = NULL ? xfree() can handle this.\n" + "> why test *buf == NULL ? xfree() can handle this.\n" "> \n" "> the question is do programm depend on *buf=NULL.\n" "> In case of IS_ERR(*buf) *buf will be left unchanged\n" @@ -40,4 +40,4 @@ "regards,\n" dan carpenter -19ecd6e1b261d59ffdf481a9bb796962b3be6751f1f8610001c6ae14bdc85c44 +17df4dc8657cb69e4c83690148049d4416b894aef50f0778b29faeb7bdaad5b1
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.