From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ie0-f172.google.com ([209.85.223.172]:33528 "EHLO mail-ie0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932081AbbDHPsD (ORCPT ); Wed, 8 Apr 2015 11:48:03 -0400 Received: by iebmp1 with SMTP id mp1so77752379ieb.0 for ; Wed, 08 Apr 2015 08:48:03 -0700 (PDT) Date: Wed, 8 Apr 2015 10:47:59 -0500 From: Bjorn Helgaas To: David Miller Cc: Yinghai Lu , David Ahern , "linux-pci@vger.kernel.org" , "sparclinux@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , Benjamin Herrenschmidt Subject: Re: [PATCH 3/3] PCI: Set pref for mem64 resource of pcie device Message-ID: <20150408154759.GN10892@google.com> References: <1427857069-6789-1-git-send-email-yinghai@kernel.org> <1427857069-6789-4-git-send-email-yinghai@kernel.org> <20150406220638.GH10892@google.com> <20150406.203533.1356187749826485194.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Sender: linux-pci-owner@vger.kernel.org List-ID: [+cc Ben] On Tue, Apr 07, 2015 at 11:48:44AM -0500, Bjorn Helgaas wrote: > On Mon, Apr 6, 2015 at 7:35 PM, David Miller wrote: > > From: Bjorn Helgaas > > Date: Mon, 6 Apr 2015 17:06:38 -0500 > > > >> But this is a general change that affects all platforms, and it's late in > >> the cycle for something as invasive as this. I'd rather include your patch > >> in the v4.1 merge window, and revert d63e2e1f3df9 ("sparc/PCI: Clip bridge > >> windows to fit in upstream windows") for v4.0. > > > > I would kindly ask that we not proceed this way and use the change > > which implements the fix properly. > > I reworked the changelog and pushed this to my for-linus branch for > v4.0. I'll ask Linus to pull it tomorrow. > > https://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/commit/?h=for-linus&id=1a3ec5e7b00dcd9cac24efe3d65bfccf82597ce5 Based on Ben's concerns, I dropped Yinghai's three patches for now: PCI: Add pci_bus_addr_t sparc/PCI: Parse 64-bit host bridge windows from OF PCI: Allow non-prefetchable PCIe BARs in prefetchable windows and reverted d63e2e1f3df9 ("sparc/PCI: Clip bridge windows to fit in upstream windows") instead. I pushed this to my for-linus branch, which I intend to merge for v4.0. You can browse it here to see if you agree: https://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/log/?h=for-linus Dave, I know you weren't happy with this proposal the first time around, but I'm not sure why. If you have a better idea, let me know. Bjorn From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Helgaas Date: Wed, 08 Apr 2015 15:47:59 +0000 Subject: Re: [PATCH 3/3] PCI: Set pref for mem64 resource of pcie device Message-Id: <20150408154759.GN10892@google.com> List-Id: References: <1427857069-6789-1-git-send-email-yinghai@kernel.org> <1427857069-6789-4-git-send-email-yinghai@kernel.org> <20150406220638.GH10892@google.com> <20150406.203533.1356187749826485194.davem@davemloft.net> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: David Miller Cc: Yinghai Lu , David Ahern , "linux-pci@vger.kernel.org" , "sparclinux@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , Benjamin Herrenschmidt [+cc Ben] On Tue, Apr 07, 2015 at 11:48:44AM -0500, Bjorn Helgaas wrote: > On Mon, Apr 6, 2015 at 7:35 PM, David Miller wrote: > > From: Bjorn Helgaas > > Date: Mon, 6 Apr 2015 17:06:38 -0500 > > > >> But this is a general change that affects all platforms, and it's late in > >> the cycle for something as invasive as this. I'd rather include your patch > >> in the v4.1 merge window, and revert d63e2e1f3df9 ("sparc/PCI: Clip bridge > >> windows to fit in upstream windows") for v4.0. > > > > I would kindly ask that we not proceed this way and use the change > > which implements the fix properly. > > I reworked the changelog and pushed this to my for-linus branch for > v4.0. I'll ask Linus to pull it tomorrow. > > https://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/commit/?h=for-linus&id3ec5e7b00dcd9cac24efe3d65bfccf82597ce5 Based on Ben's concerns, I dropped Yinghai's three patches for now: PCI: Add pci_bus_addr_t sparc/PCI: Parse 64-bit host bridge windows from OF PCI: Allow non-prefetchable PCIe BARs in prefetchable windows and reverted d63e2e1f3df9 ("sparc/PCI: Clip bridge windows to fit in upstream windows") instead. I pushed this to my for-linus branch, which I intend to merge for v4.0. You can browse it here to see if you agree: https://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/log/?h=for-linus Dave, I know you weren't happy with this proposal the first time around, but I'm not sure why. If you have a better idea, let me know. Bjorn