From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Wed, 8 Apr 2015 18:13:55 +0200 Subject: [Cluster-devel] [PATCH 2/2][v2] blk-plug: don't flush nested plug lists In-Reply-To: References: <1428347694-17704-1-git-send-email-jmoyer@redhat.com> <1428347694-17704-2-git-send-email-jmoyer@redhat.com> Message-ID: <20150408161355.GA16052@lst.de> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit This looks good, but without the blk_finish_plug argument we're bound to grow programming mistakes where people forget it. Any chance we could have annotations similar to say rcu_read_lock/rcu_read_unlock or the spinlocks so that sparse warns about it? From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 2/2][v2] blk-plug: don't flush nested plug lists Date: Wed, 8 Apr 2015 18:13:55 +0200 Message-ID: <20150408161355.GA16052@lst.de> References: <1428347694-17704-1-git-send-email-jmoyer@redhat.com> <1428347694-17704-2-git-send-email-jmoyer@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org To: Jeff Moyer Cc: Jens Axboe , Ming Lei , Konrad Rzeszutek Wilk , Roger Pau Monn?? , Alasdair Kergon , Mike Snitzer , Neil Brown , "Nicholas A. Bellinger" , Alexander Viro , Chris Mason , Josef Bacik , David Sterba , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , Changman Lee , Steven Whitehouse , Mikulas Patocka , Andrew Morton , Rik van Riel , Johannes Weiner , Mel Gorman , Trond Myklebust Anna Schumaker List-Id: dm-devel.ids This looks good, but without the blk_finish_plug argument we're bound to grow programming mistakes where people forget it. Any chance we could have annotations similar to say rcu_read_lock/rcu_read_unlock or the spinlocks so that sparse warns about it? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 2/2][v2] blk-plug: don't flush nested plug lists Date: Wed, 8 Apr 2015 18:13:55 +0200 Message-ID: <20150408161355.GA16052@lst.de> References: <1428347694-17704-1-git-send-email-jmoyer@redhat.com> <1428347694-17704-2-git-send-email-jmoyer@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jens Axboe , Ming Lei , Konrad Rzeszutek Wilk , Roger Pau Monn?? , Alasdair Kergon , Mike Snitzer , Neil Brown , "Nicholas A. Bellinger" , Alexander Viro , Chris Mason , Josef Bacik , David Sterba , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , Changman Lee , Steven Whitehouse , Mikulas Patocka , Andrew Morton , Rik van Riel , Johannes Weiner , Mel Gorman , Trond Myklebust , Anna Schumaker Return-path: Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-Id: linux-ext4.vger.kernel.org This looks good, but without the blk_finish_plug argument we're bound to grow programming mistakes where people forget it. Any chance we could have annotations similar to say rcu_read_lock/rcu_read_unlock or the spinlocks so that sparse warns about it? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id B1CB77F7C for ; Wed, 8 Apr 2015 11:14:02 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay1.corp.sgi.com (Postfix) with ESMTP id A10FC8F8068 for ; Wed, 8 Apr 2015 09:13:59 -0700 (PDT) Received: from newverein.lst.de (verein.lst.de [213.95.11.211]) by cuda.sgi.com with ESMTP id E8cJkRi91pvcA291 (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Wed, 08 Apr 2015 09:13:57 -0700 (PDT) Date: Wed, 8 Apr 2015 18:13:55 +0200 From: Christoph Hellwig Subject: Re: [PATCH 2/2][v2] blk-plug: don't flush nested plug lists Message-ID: <20150408161355.GA16052@lst.de> References: <1428347694-17704-1-git-send-email-jmoyer@redhat.com> <1428347694-17704-2-git-send-email-jmoyer@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Jeff Moyer Cc: Vladimir Davydov , linux-aio@kvack.org, Miklos Szeredi , Mike Snitzer , Neil Brown , Ming Lei , Ming Lei , Trond Myklebust , Jianyu Zhan , "Nicholas A. Bellinger" , linux-kernel@vger.kernel.org, Sagi Grimberg , Chris Mason , dm-devel@redhat.com, target-devel@vger.kernel.org, Andreas Dilger , Mikulas Patocka , Mark Rustad , Christoph Hellwig , Alasdair Kergon , Matthew Wilcox , linux-scsi@vger.kernel.org, Namjae Jeon , linux-raid@vger.kernel.org, cluster-devel@redhat.com, Mel Gorman , Suleiman Souhlal , linux-ext4@vger.kernel.org, linux-mm@kvack.org, Changman Lee , Rik van Riel , Konrad Rzeszutek Wilk , xfs@oss.sgi.com, Fabian Frederick , Joe Perches , Alexander Viro , xen-devel@lists.xenproject.org, Jaegeuk Kim , Steven Whitehouse , Vlastimil Babka , Jens Axboe , Michal Hocko , linux-nfs@vger.kernel.org, Fengguang Wu , Theodore Ts'o , "Martin K. Petersen" , Wang Sheng-Hui , Josef Bacik , David Sterba , linux-f2fs-devel@lists.sourceforge.net, linux-btrfs@vger.kernel.org, Johannes Weiner , Tejun Heo , linux-fsdevel@vger.kernel.org, Andrew Morton , Weston Andros Adamson , Anna Schumaker , "Kirill A. Shutemov" , Roger Pau Monn?? This looks good, but without the blk_finish_plug argument we're bound to grow programming mistakes where people forget it. Any chance we could have annotations similar to say rcu_read_lock/rcu_read_unlock or the spinlocks so that sparse warns about it? _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com [209.85.212.176]) by kanga.kvack.org (Postfix) with ESMTP id 391076B0032 for ; Wed, 8 Apr 2015 12:13:58 -0400 (EDT) Received: by wizk4 with SMTP id k4so61149543wiz.1 for ; Wed, 08 Apr 2015 09:13:57 -0700 (PDT) Date: Wed, 8 Apr 2015 18:13:55 +0200 From: Christoph Hellwig Subject: Re: [PATCH 2/2][v2] blk-plug: don't flush nested plug lists Message-ID: <20150408161355.GA16052@lst.de> References: <1428347694-17704-1-git-send-email-jmoyer@redhat.com> <1428347694-17704-2-git-send-email-jmoyer@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Jeff Moyer Cc: Jens Axboe , Ming Lei , Konrad Rzeszutek Wilk , Roger Pau Monn?? , Alasdair Kergon , Mike Snitzer , Neil Brown , "Nicholas A. Bellinger" , Alexander Viro , Chris Mason , Josef Bacik , David Sterba , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , Changman Lee , Steven Whitehouse , Mikulas Patocka , Andrew Morton , Rik van Riel , Johannes Weiner , Mel Gorman , Trond Myklebust , Anna Schumaker , Dave Chinner , xfs@oss.sgi.com, Christoph Hellwig , Weston Andros Adamson , "Martin K. Petersen" , Sagi Grimberg , Tejun Heo , Fabian Frederick , Matthew Wilcox , Ming Lei , "Kirill A. Shutemov" , Wang Sheng-Hui , Michal Hocko , Joe Perches , Miklos Szeredi , Namjae Jeon , Mark Rustad , Jianyu Zhan , Fengguang Wu , Vladimir Davydov , Vlastimil Babka , Suleiman Souhlal , linux-kernel@vger.kernel.org, dm-devel@redhat.com, xen-devel@lists.xenproject.org, linux-raid@vger.kernel.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-aio@kvack.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mm@kvack.org This looks good, but without the blk_finish_plug argument we're bound to grow programming mistakes where people forget it. Any chance we could have annotations similar to say rcu_read_lock/rcu_read_unlock or the spinlocks so that sparse warns about it? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org