From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34365) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YfwNj-0000FX-AY for qemu-devel@nongnu.org; Wed, 08 Apr 2015 16:15:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YfwNe-0001PF-K1 for qemu-devel@nongnu.org; Wed, 08 Apr 2015 16:15:27 -0400 Received: from e39.co.us.ibm.com ([32.97.110.160]:41208) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YfwNe-0001P8-C6 for qemu-devel@nongnu.org; Wed, 08 Apr 2015 16:15:22 -0400 Received: from /spool/local by e39.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 8 Apr 2015 14:15:20 -0600 Received: from b03cxnp08027.gho.boulder.ibm.com (b03cxnp08027.gho.boulder.ibm.com [9.17.130.19]) by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id 592C419D804A for ; Wed, 8 Apr 2015 14:06:09 -0600 (MDT) Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by b03cxnp08027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t38KF3Of37224534 for ; Wed, 8 Apr 2015 13:15:03 -0700 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t38KF1Rj024309 for ; Wed, 8 Apr 2015 14:15:02 -0600 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Roth In-Reply-To: <1428523369-13700-1-git-send-email-peter.maydell@linaro.org> References: <1428523369-13700-1-git-send-email-peter.maydell@linaro.org> Message-ID: <20150408201457.31597.59840@loki> Date: Wed, 08 Apr 2015 15:14:57 -0500 Subject: Re: [Qemu-devel] [PATCH] qga/commands-posix.c: Use correct types with g_base64_decode() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-devel@nongnu.org Cc: patches@linaro.org Quoting Peter Maydell (2015-04-08 15:02:49) > The second argument of g_base64_decode() is a 'gsize *', not a > 'size_t *'. Some compilation environments (like building 32-bit PPC > binaries on a PPC64 system) will complain about the mismatch: > = > CC qga/commands-posix.o > qga/commands-posix.c: In function 'qmp_guest_set_user_password': > qga/commands-posix.c:1908:5: error: passing argument 2 of 'g_base64_decod= e' from incompatible pointer type [-Werror] > In file included from /usr/include/glib-2.0/glib.h:37:0, > from qga/commands-posix.c:14: > /usr/include/glib-2.0/glib/gbase64.h:49:9: note: expected =E2=80=98gsize = *=E2=80=99 but argument is of type =E2=80=98size_t *=E2=80=99 > = > (We previously fixed errors of this type in commit 3d1bba20.) > = > Signed-off-by: Peter Maydell Reviewed-by: Michael Roth Thanks for the catch/patch! Assuming you're applying directly, but otherwise let me know and I'll send a pull within the hour. > --- > qga/commands-posix.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > = > diff --git a/qga/commands-posix.c b/qga/commands-posix.c > index ba8de62..9fde348 100644 > --- a/qga/commands-posix.c > +++ b/qga/commands-posix.c > @@ -1901,7 +1901,7 @@ void qmp_guest_set_user_password(const char *userna= me, > int status; > int datafd[2] =3D { -1, -1 }; > char *rawpasswddata =3D NULL; > - size_t rawpasswdlen; > + gsize rawpasswdlen; > char *chpasswddata =3D NULL; > size_t chpasswdlen; > = > -- = > 1.9.1