All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>
Cc: mingo@redhat.com, bp@suse.de, tglx@linutronix.de, hpa@zytor.com,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	konrad.wilk@oracle.com
Subject: Re: [PATCH] x86, iommu: Fix header comments regarding standard and _FINISH macros
Date: Thu, 9 Apr 2015 09:37:44 +0200	[thread overview]
Message-ID: <20150409073743.GB31471@gmail.com> (raw)
In-Reply-To: <1428508017-5316-1-git-send-email-Aravind.Gopalakrishnan@amd.com>


* Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com> wrote:

> The comment line regarding IOMMU_INIT and IOMMU_INIT_FINISH macros
> is incorrect:
> "The standard vs the _FINISH differs in that the _FINISH variant will
>  continue detecting other IOMMUs in the call list..."
> It should be "..the *standard* variant will continue detecting..."
> 
> Fix that.
> 
> Signed-off-by: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>
> ---
>  arch/x86/include/asm/iommu_table.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/include/asm/iommu_table.h b/arch/x86/include/asm/iommu_table.h
> index f42a047..16845d4 100644
> --- a/arch/x86/include/asm/iommu_table.h
> +++ b/arch/x86/include/asm/iommu_table.h
> @@ -79,7 +79,7 @@ struct iommu_table_entry {
>   *  d). Similar to the 'init', except that this gets called from pci_iommu_init
>   *      where we do have a memory allocator.
>   *
> - * The standard vs the _FINISH differs in that the _FINISH variant will
> + * The standard vs the _FINISH differs in that the standard variant will
>   * continue detecting other IOMMUs in the call list after the
>   * the detection routine returns a positive number. The _FINISH will
>   * stop the execution chain. Both will still call the 'init' and

So while we are touching it, how about making it more readable:

    *
    * The standard vs the _FINISH variants differ in that the
    * standard variant will continue detecting other IOMMUs in the 
    * call list after the detection routine returns a positive number. 
    * The _FINISH variant will stop the execution chain. Both variants 
    * will still call the 'init' and ...
    *

I also fixed a 'the the' typo.

Thanks,

	Ingo

  parent reply	other threads:[~2015-04-09  7:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-08 15:46 [PATCH] x86, iommu: Fix header comments regarding standard and _FINISH macros Aravind Gopalakrishnan
2015-04-09  7:27 ` Borislav Petkov
2015-04-09  7:37 ` Ingo Molnar [this message]
2015-04-09  7:54   ` Borislav Petkov
2015-04-09  8:02     ` Ingo Molnar
2015-04-09 10:31     ` Konrad Rzeszutek Wilk
2015-04-09 10:38       ` Borislav Petkov
2015-04-09  9:04 ` [tip:x86/cleanups] x86/iommu: " tip-bot for Aravind Gopalakrishnan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150409073743.GB31471@gmail.com \
    --to=mingo@kernel.org \
    --cc=Aravind.Gopalakrishnan@amd.com \
    --cc=bp@suse.de \
    --cc=hpa@zytor.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.