From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934341AbbDIJzZ (ORCPT ); Thu, 9 Apr 2015 05:55:25 -0400 Received: from mail.skyhub.de ([78.46.96.112]:53538 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932603AbbDIJzV (ORCPT ); Thu, 9 Apr 2015 05:55:21 -0400 Date: Thu, 9 Apr 2015 11:53:08 +0200 From: Borislav Petkov To: Naoya Horiguchi Cc: Ingo Molnar , Tony Luck , Prarit Bhargava , Vivek Goyal , "linux-kernel@vger.kernel.org" , Junichi Nomura , Kiyoshi Ueda Subject: Re: [PATCH v8] x86: mce: kexec: switch MCE handler for kexec/kdump Message-ID: <20150409095308.GG25434@pd.tnic> References: <20150306093212.GB14982@hori1.linux.bs1.fc.nec.co.jp> <20150306102216.GA22787@hori1.linux.bs1.fc.nec.co.jp> <20150406071803.GA22950@hori1.linux.bs1.fc.nec.co.jp> <20150406115923.GD4078@pd.tnic> <20150407080017.GB27856@hori1.linux.bs1.fc.nec.co.jp> <20150407080218.GC27856@hori1.linux.bs1.fc.nec.co.jp> <20150409061346.GA25434@pd.tnic> <20150409080030.GA4713@gmail.com> <20150409082125.GE25434@pd.tnic> <20150409085944.GA27042@hori1.linux.bs1.fc.nec.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150409085944.GA27042@hori1.linux.bs1.fc.nec.co.jp> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 09, 2015 at 08:59:44AM +0000, Naoya Horiguchi wrote: > I replied about testing. That might be tricky a little, but I hope it helps. Yeah, whatever we do, we need this properly tested before upstreaming. That's a given. > Even if we raise tolerant level in running kdump, that doesn't prevent > idling CPUs from running MCE handlers when MCE arrives, which makes memory > accesses (losing information from kdump's viewpoint) and spits > "MCE synchronization timeout" messages (unclear and confusing for users.) Why? Those CPUs are offlined and num_online_cpus() in mce_start() should account for that, no? And if those are offlined, they're very very unlikely to trigger an MCE as they're idle and not executing code. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --