Re: [PATCH] drm/i915: Fix the VBT child device parsing for BSW

From: Damien Lespiau <damien.lespiau@intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Fix the VBT child device parsing for BSW
Date: Thu, 9 Apr 2015 11:56:36 +0100	[thread overview]
Message-ID: <20150409105636.GA12621@strange.ger.corp.intel.com> (raw)
In-Reply-To: <20150409103710.GQ17410@intel.com>

On Thu, Apr 09, 2015 at 01:37:10PM +0300, Ville Syrjälä wrote:
> On Thu, Apr 09, 2015 at 09:49:25AM +0100, Damien Lespiau wrote:
> > On Wed, Mar 25, 2015 at 06:45:58PM +0200, ville.syrjala@linux.intel.com wrote:
> > > +static union child_device_config *
> > > +child_device_ptr(struct bdb_general_definitions *p_defs, int i)
> > > +{
> > > +	return (void *) &p_defs->devices[i * p_defs->child_dev_size];
> > > +}
> > 
> > Actually this looks wrong. We're doing:
> > 
> >   p_defs->devices + sizeof(union child_device_config) * i * child_dev_size
> > 
> > instead of:
> > 
> >   (u8)p_defs->devices + i * child_dev_size
> > 
> > ?
> 
> The patch also had:
> -     union child_device_config devices[0];
> +     uint8_t devices[0];

Ah, yes! oops

-- 
Damien
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx