From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Westphal Subject: Re: [FYI] xfrm: Don't lookup sk_policy for timewait sockets Date: Thu, 9 Apr 2015 21:14:41 +0200 Message-ID: <20150409191441.GE20653@breakpoint.cc> References: <1428566941.6875.7.camel@googlemail.com> <1428570461.25985.240.camel@edumazet-glaptop2.roam.corp.google.com> <20150409.143727.1391401196320839634.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: eric.dumazet@gmail.com, sebastian.poehn@gmail.com, netdev@vger.kernel.org To: David Miller Return-path: Received: from Chamillionaire.breakpoint.cc ([80.244.247.6]:56370 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755753AbbDITOq (ORCPT ); Thu, 9 Apr 2015 15:14:46 -0400 Content-Disposition: inline In-Reply-To: <20150409.143727.1391401196320839634.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: David Miller wrote: > From: Eric Dumazet > Date: Thu, 09 Apr 2015 02:07:41 -0700 > > > TCP stack never sends packets attached to a socket in timewait state. > > TPROXY assigns timewait sockets to skb->sk, that's the bug. I re-introduced this in fd158d79d33d3c under the assumption that the input path handles skb->sk timewait sockets correctly after all the early demux changes, afaics tcp edemux can also assign skb->sk timewait sockets. Also, reporter mentions 3.8 as affected which should not assign tw sockets to skb->sk. Even more strange, the reporters backtrace seems to indicate crash at end of forward path. Sebastian, can you disable tw assignment via TPROXY in 3.12 just to see if it makes a difference? [ not doing the assignment is safe provided you still set tproxy mark on the skb; policy routing will ensure local delivery ].