From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chao Peng <chao.p.peng@linux.intel.com>
Subject: Re: [PATCH v4 04/12] x86: maintain COS to CBM mapping
	for each socket
Date: Fri, 10 Apr 2015 15:26:56 +0800
Message-ID: <20150410072656.GB3417@pengc-linux.bj.intel.com>
References: <1428571105-3604-1-git-send-email-chao.p.peng@linux.intel.com>
	<1428571105-3604-5-git-send-email-chao.p.peng@linux.intel.com>
	<5526F0AF.4020006@citrix.com>
Reply-To: Chao Peng <chao.p.peng@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <5526F0AF.4020006@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: keir@xen.org, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org, will.auld@intel.com, JBeulich@suse.com, wei.liu2@citrix.com, dgdegra@tycho.nsa.gov
List-Id: xen-devel@lists.xenproject.org

On Thu, Apr 09, 2015 at 10:35:43PM +0100, Andrew Cooper wrote:
> On 09/04/2015 10:18, Chao Peng wrote:
> >  struct psr_cat_socket_info {
> >      bool_t initialized;
> >      bool_t enabled;
> >      unsigned int cbm_len;
> >      unsigned int cos_max;
> > +    struct psr_cat_cbm *cos_cbm_map;
> 
> "cos_to_cmb" would be more in keeping with Xen style, and IMO easier to
> read in code.

Yeah, I like this name.

> 
> >  };
> >  
> >  struct psr_assoc {
> > @@ -240,6 +246,14 @@ static void cat_cpu_init(unsigned int cpu)
> >          info->cbm_len = (eax & 0x1f) + 1;
> >          info->cos_max = (edx & 0xffff);
> 
> Apologies for missing this in the previous patch, but cos_max should
> have a command line parameter like rmid_max if a lower limit wants to be
> enforced.

OK, I will add it.

Thanks,
Chao