From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chao Peng Subject: Re: [PATCH v4 06/12] x86: add COS information for each domain Date: Fri, 10 Apr 2015 15:35:18 +0800 Message-ID: <20150410073518.GD3417@pengc-linux.bj.intel.com> References: <1428571105-3604-1-git-send-email-chao.p.peng@linux.intel.com> <1428571105-3604-7-git-send-email-chao.p.peng@linux.intel.com> <5526F4F8.3050103@citrix.com> Reply-To: Chao Peng Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <5526F4F8.3050103@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper Cc: keir@xen.org, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org, will.auld@intel.com, JBeulich@suse.com, wei.liu2@citrix.com, dgdegra@tycho.nsa.gov List-Id: xen-devel@lists.xenproject.org On Thu, Apr 09, 2015 at 10:54:00PM +0100, Andrew Cooper wrote: > On 09/04/2015 10:18, Chao Peng wrote: > > + { > > + d->arch.psr_cos_ids = xzalloc_array(unsigned int, nr_sockets); > > It is perhaps worth leaving a comment in patch 3 stating that nr_sockets > must never change after domains have been created. > > That, or whomever implements CAT/socket hotplug support has to fix this > issue. (I think the code is fine to leave in its current state, but > nr_sockets changing under the feet of Xen will be a subtle bug for > someone to track down) > > Otherwise, Reviewed-by: Andrew Cooper That's right, keep nr_sockets as constant at runtime is the basic assumption. Chao