From: Daniel Vetter <daniel@ffwll.ch>
To: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 02/11] drm/i915: Remove stale comment from __intel_set_mode()
Date: Fri, 10 Apr 2015 11:37:29 +0200 [thread overview]
Message-ID: <20150410093729.GC6092@phenom.ffwll.local> (raw)
In-Reply-To: <1428655120-22494-3-git-send-email-ander.conselvan.de.oliveira@intel.com>
On Fri, Apr 10, 2015 at 11:38:31AM +0300, Ander Conselvan de Oliveira wrote:
> Since the following commit, the PLL calculations are done earlier, so
> the code following the comment doesn't do anything PLL or encoder
> related. It only updates the primary plane now.
>
> commit f3019a4d92f08b2dd92443a4b567a066a51c6ec0
> Author: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> Date: Wed Oct 29 11:32:37 2014 +0200
>
> drm/i915: Remove crtc_mode_set() hook
>
> Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Queued for -next, thanks for the patch.
-Daniel
> ---
> drivers/gpu/drm/i915/intel_display.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 2263a71..894788d 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -11737,9 +11737,6 @@ static int __intel_set_mode(struct drm_crtc *crtc,
>
> modeset_update_crtc_power_domains(state);
>
> - /* Set up the DPLL and any encoders state that needs to adjust or depend
> - * on the DPLL.
> - */
> for_each_intel_crtc_masked(dev, modeset_pipes, intel_crtc) {
> struct drm_plane *primary = intel_crtc->base.primary;
> int vdisplay, hdisplay;
> --
> 2.1.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-04-10 9:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-10 8:38 [PATCH 00/11] Small modeset refactoring Ander Conselvan de Oliveira
2015-04-10 8:38 ` [PATCH 01/11] drm/i915: Allocate connector state together with the connectors Ander Conselvan de Oliveira
2015-04-10 8:38 ` [PATCH 02/11] drm/i915: Remove stale comment from __intel_set_mode() Ander Conselvan de Oliveira
2015-04-10 9:37 ` Daniel Vetter [this message]
2015-04-10 9:39 ` Daniel Vetter
2015-04-10 8:38 ` [PATCH 03/11] drm/i915: Reset changed flags when duplicating crtc state Ander Conselvan de Oliveira
2015-04-10 9:39 ` Daniel Vetter
2015-04-13 11:07 ` Jani Nikula
2015-04-10 8:38 ` [PATCH 04/11] drm/i915: Add for_each_connector_in_state helper macro Ander Conselvan de Oliveira
2015-04-10 9:42 ` Daniel Vetter
2015-04-10 10:50 ` Ander Conselvan De Oliveira
2015-04-10 8:38 ` [PATCH 05/11] drm/i915: Extract mode_changed computation out of stage_output_config() Ander Conselvan de Oliveira
2015-04-10 10:07 ` Daniel Vetter
2015-04-10 8:38 ` [PATCH 06/11] drm/i915: Add crtc states before calling compute_config() Ander Conselvan de Oliveira
2015-04-10 8:38 ` [PATCH 07/11] drm/i915: Remove all *_pipes flags from modeset Ander Conselvan de Oliveira
2015-04-10 9:54 ` Daniel Vetter
2015-04-10 8:38 ` [PATCH 08/11] drm/i915: Remove saved_mode from __intel_set_mode() Ander Conselvan de Oliveira
2015-04-10 8:38 ` [PATCH 09/11] drm/i915: Move compute part of __intel_set_mode() to separate function Ander Conselvan de Oliveira
2015-04-10 8:38 ` [PATCH 10/11] drm/i915: Simplify error handling in __intel_set_mode() Ander Conselvan de Oliveira
2015-04-10 8:38 ` [PATCH 11/11] drm/i915: Don't modeset with old mode when set_crtc fails Ander Conselvan de Oliveira
2015-04-10 10:12 ` Daniel Vetter
2015-04-10 10:24 ` Ander Conselvan De Oliveira
2015-04-10 13:27 ` shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150410093729.GC6092@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=ander.conselvan.de.oliveira@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.