All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Alberto Garcia <berto@igalia.com>,
	qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-block] [RFC] Intermediate block mirroring
Date: Fri, 10 Apr 2015 15:02:52 +0200	[thread overview]
Message-ID: <20150410130252.GC4288@noname.redhat.com> (raw)
In-Reply-To: <20150410095623.GB23555@stefanha-thinkpad.redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1507 bytes --]

Am 10.04.2015 um 11:56 hat Stefan Hajnoczi geschrieben:
> On Thu, Apr 09, 2015 at 02:40:00PM +0200, Alberto Garcia wrote:
> > On Thu, Apr 09, 2015 at 11:39:28AM +0100, Stefan Hajnoczi wrote:
> > 
> > > > The goal would be to convert this:
> > > > 
> > > >    [A] -> [B] -> [C] -> [D]
> > > > 
> > > > into this:
> > > > 
> > > >    [A] -> [B] -> [X] -> [D]
> > > > 
> > > > where [D] is the active image and [X] would be a copy of [C]. The
> > > > latter would be unlinked from the chain.
> > > > 
> > > > A use case would be to move disk images across different storage
> > > > backends.
> > > 
> > > The simple solution to that problem is:
> > > 
> > > Assumption: backing files are read only.  (True in most cases.)
> > > 
> > > 1. Copy the backing files using cp(1) or another method.
> > > 2. Issue QMP 'change-backing-file' command so that [D] uses [X] instead
> > >    of [C].
> > > 
> > > So it can be done today already.
> > 
> > So do you think it would be better to implement this somewhere else?
> > The code that I have for QEMU is quite simple, the actual algorithm
> > doesn't change, it only needs to do the changing of backing files in
> > mirror_exit().
> 
> I'll take a look at your patch series, maybe there are advantages to
> doing it within QEMU.

If the patches are simple, I think consistency and avoiding arbitrary
restrictions are good enough reasons for having the support in qemu.
Eventually we want all nodes to be equal anyway.

Kevin

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

      reply	other threads:[~2015-04-10 13:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-02 13:28 [Qemu-devel] [RFC] Intermediate block mirroring Alberto Garcia
2015-04-02 16:56 ` Eric Blake
2015-04-09 10:39 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2015-04-09 12:40   ` Alberto Garcia
2015-04-10  9:56     ` Stefan Hajnoczi
2015-04-10 13:02       ` Kevin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150410130252.GC4288@noname.redhat.com \
    --to=kwolf@redhat.com \
    --cc=berto@igalia.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.