From mboxrd@z Thu Jan  1 00:00:00 1970
Received: with ECARTIS (v1.0.0; list linux-mips); Fri, 10 Apr 2015 15:47:16 +0200 (CEST)
Received: from localhost.localdomain ([127.0.0.1]:40268 "EHLO linux-mips.org"
        rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP
        id S27010902AbbDJNrOrs6qU (ORCPT <rfc822;linux-mips@linux-mips.org>);
        Fri, 10 Apr 2015 15:47:14 +0200
Received: from scotty.linux-mips.net (localhost.localdomain [127.0.0.1])
        by scotty.linux-mips.net (8.14.9/8.14.8) with ESMTP id t3ADlDlB007383;
        Fri, 10 Apr 2015 15:47:13 +0200
Received: (from ralf@localhost)
        by scotty.linux-mips.net (8.14.9/8.14.9/Submit) id t3ADlBuE007380;
        Fri, 10 Apr 2015 15:47:11 +0200
Date:   Fri, 10 Apr 2015 15:47:11 +0200
From:   Ralf Baechle <ralf@linux-mips.org>
To:     Lars Persson <lars.persson@axis.com>
Cc:     paul.burton@imgtec.com, linux-mips@linux-mips.org,
        linux-kernel@vger.kernel.org, Lars Persson <larper@axis.com>
Subject: Re: [PATCH] MIPS: Fix HIGHMEM crash in __update_cache().
Message-ID: <20150410134711.GC21107@linux-mips.org>
References: <1428672084-20676-1-git-send-email-larper@axis.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1428672084-20676-1-git-send-email-larper@axis.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Return-Path: <ralf@linux-mips.org>
X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0)
X-Orcpt: rfc822;linux-mips@linux-mips.org
Original-Recipient: rfc822;linux-mips@linux-mips.org
X-archive-position: 46850
X-ecartis-version: Ecartis v1.0.0
Sender: linux-mips-bounce@linux-mips.org
Errors-to: linux-mips-bounce@linux-mips.org
X-original-sender: ralf@linux-mips.org
Precedence: bulk
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
List-software: Ecartis version 1.0.0
List-Id: linux-mips <linux-mips.eddie.linux-mips.org>
X-List-ID: linux-mips <linux-mips.eddie.linux-mips.org>
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
X-list: linux-mips

On Fri, Apr 10, 2015 at 03:21:24PM +0200, Lars Persson wrote:

> Commit 8b5fe5e54b47 ("MIPS: Fix race condition in lazy cache flushing.")
> triggered NULL pointer dereferences on systems with HIGHMEM.
> 
> The problem was caused by not clearing the PG_dcache_dirty flag in
> flush_icache_page() and thus we enter __update_cache() that lacks
> support for HIGHMEM.

Thanks, I've folded this patch into the original 8b5fe5e54b47 commit.

  Ralf