From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756775AbbDJUwK (ORCPT ); Fri, 10 Apr 2015 16:52:10 -0400 Received: from mga02.intel.com ([134.134.136.20]:49240 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756174AbbDJUwH (ORCPT ); Fri, 10 Apr 2015 16:52:07 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,558,1422950400"; d="scan'208";a="712017258" Date: Fri, 10 Apr 2015 13:52:05 -0700 From: Andi Kleen To: Borislav Petkov Cc: Andy Lutomirski , Andi Kleen , X86 ML , Andrew Lutomirski , "linux-kernel@vger.kernel.org" , Steven Rostedt Subject: Re: [PATCH 4/8] x86: Add support for rd/wr fs/gs base Message-ID: <20150410205205.GU15335@tassilo.jf.intel.com> References: <1428681033-1549-1-git-send-email-andi@firstfloor.org> <1428681033-1549-5-git-send-email-andi@firstfloor.org> <20150410202132.GQ15335@tassilo.jf.intel.com> <20150410202542.GA28317@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150410202542.GA28317@pd.tnic> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 10, 2015 at 10:25:42PM +0200, Borislav Petkov wrote: > On Fri, Apr 10, 2015 at 01:21:32PM -0700, Andi Kleen wrote: > > > Is there some reason that the normal ALTERNATIVE macro can't be used here? > > > > This is assembler, not C. > > He's talking about the ALTERNATIVE asm macro in alternative-asm.h in > tip/master now. No open coded crap. I don't think that macro works jumps that are patched in (and probably should have never been added because of that) -Andi -- ak@linux.intel.com -- Speaking for myself only