From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Sun, 12 Apr 2015 19:20:51 +0200 Subject: [Buildroot] [autobuild 1/4] autobuild-run: prevent send_result from failing when gathering config files In-Reply-To: <1428849285-21092-1-git-send-email-s.martin49@gmail.com> References: <1428849285-21092-1-git-send-email-s.martin49@gmail.com> Message-ID: <20150412192051.5d747e28@free-electrons.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Dear Samuel Martin, On Sun, 12 Apr 2015 16:34:42 +0200, Samuel Martin wrote: > - Make sure using absolute paths in os.path.relpath(); > - os.makedirs() can fail if the directory already exists, so only create it > when needed. > > Signed-off-by: Samuel Martin > --- > scripts/autobuild-run | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/scripts/autobuild-run b/scripts/autobuild-run > index 0e12080..a19d51b 100755 > --- a/scripts/autobuild-run > +++ b/scripts/autobuild-run > @@ -653,15 +653,16 @@ def send_results(result, **kwargs): > if not reason: > return > > - srcroot = os.path.join(outputdir, "build", '-'.join(reason)) > - destroot = os.path.join(resultdir, '-'.join(reason)) > + srcroot = os.path.abspath(os.path.join(outputdir, "build", '-'.join(reason))) > + destroot = os.path.abspath(os.path.join(resultdir, '-'.join(reason))) Can you explain why this is needed? Thanks, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com