From: Sascha Hauer <s.hauer@pengutronix.de>
To: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: "Thomas Petazzoni" <thomas.petazzoni@free-electrons.com>,
barebox@lists.infradead.org,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH 2/4] net: mvneta: Fix transmit errors due to dirty txdesc
Date: Mon, 13 Apr 2015 08:43:10 +0200 [thread overview]
Message-ID: <20150413064310.GW9742@pengutronix.de> (raw)
In-Reply-To: <1428627714-17077-3-git-send-email-sebastian.hesselbarth@gmail.com>
On Fri, Apr 10, 2015 at 03:01:52AM +0200, Sebastian Hesselbarth wrote:
> Marvell Neta's transmit descriptor (txdesc) is allocated by dma_alloc_coherent()
> but not zeroed before calling mvneta_send the first time. This can cause spurious
> transmit errors due to improperly set bits in txdesc's cmd_sts field.
>
> Fix initial transmit errors by always writing whole cmd_sts field instead of ORing
> the bits.
>
> Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> ---
> Cc: barebox@lists.infradead.org
> Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Cc: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> drivers/net/mvneta.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied this one, thanks
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2015-04-13 6:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-10 1:01 [PATCH 0/4] Some fixes for PCI, mvneta, xHCI Sebastian Hesselbarth
2015-04-10 1:01 ` [PATCH 1/4] pci: fix device registration for directly attached devices Sebastian Hesselbarth
2015-04-10 7:15 ` Lucas Stach
2015-04-10 8:24 ` Sebastian Hesselbarth
2015-04-10 1:01 ` [PATCH 2/4] net: mvneta: Fix transmit errors due to dirty txdesc Sebastian Hesselbarth
2015-04-13 6:43 ` Sascha Hauer [this message]
2015-04-10 1:01 ` [PATCH 3/4] net: mvneta: Remove unnecessary DMA ops Sebastian Hesselbarth
2015-04-10 7:23 ` Lucas Stach
2015-04-10 8:18 ` Sebastian Hesselbarth
2015-04-10 16:09 ` Jan Lübbe
2015-04-10 1:01 ` [PATCH 4/4] USB: xHCI: Sync non-coherent DMA buffers Sebastian Hesselbarth
2015-04-10 7:25 ` Lucas Stach
2015-04-13 14:22 ` [PATCH v2] " Sebastian Hesselbarth
2015-04-14 18:52 ` Sascha Hauer
2015-04-14 19:29 ` Sebastian Hesselbarth
2015-04-15 9:11 ` Lucas Stach
2015-04-15 9:10 ` Lucas Stach
2015-04-15 12:06 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150413064310.GW9742@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.