All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@fb.com>
Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org,
	linux-scsi@vger.kernel.org, hch@lst.de
Subject: Re: [PATCH 2/6] scsi: ensure that a request is valid when returning it from scsi_find_tag()
Date: Mon, 13 Apr 2015 11:47:19 +0200	[thread overview]
Message-ID: <20150413094719.GC5259@lst.de> (raw)
In-Reply-To: <1428427120-20971-3-git-send-email-axboe@fb.com>

On Tue, Apr 07, 2015 at 11:18:36AM -0600, Jens Axboe wrote:
> For the scsi-mq case, ensure that the request has been started before
> returning it from scsi_find_tag(). This is akin to the ->special
> check for the non-mq case, it ensures that the request has been setup
> and issued.
> 
> Signed-off-by: Jens Axboe <axboe@fb.com>

Shouldn't this be done in blk_mq_tag_to_rq?  In general when a driver
looks for an active tag it wants an active tag, so working around
this in the driver seems like a bad idea.

  reply	other threads:[~2015-04-13  9:47 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-07 17:18 [PATCH RFC v2] mpt2/mpt3sas lock reduction for scsi-mq Jens Axboe
2015-04-07 17:18 ` Jens Axboe
2015-04-07 17:18 ` [PATCH 1/6] scsi: add host template init/exit_command hooks Jens Axboe
2015-04-07 17:18   ` Jens Axboe
2015-04-07 17:18 ` [PATCH 2/6] scsi: ensure that a request is valid when returning it from scsi_find_tag() Jens Axboe
2015-04-07 17:18   ` Jens Axboe
2015-04-13  9:47   ` Christoph Hellwig [this message]
2015-04-07 17:18 ` [PATCH 3/6] mpt2sas: get rid of MPI2_FUNCTION_SCSI_TASK_MGMT Jens Axboe
2015-04-07 17:18   ` Jens Axboe
2015-04-13  9:49   ` Christoph Hellwig
2015-04-07 17:18 ` [PATCH 4/6] mpt2sas: store scsi io tracker data in the scsi request Jens Axboe
2015-04-07 17:18   ` Jens Axboe
2015-04-13  9:49   ` Christoph Hellwig
2015-04-07 17:18 ` [PATCH 5/6] mpt3sas: get rid of MPI2_FUNCTION_SCSI_TASK_MGMT Jens Axboe
2015-04-07 17:18   ` Jens Axboe
2015-04-07 17:18 ` [PATCH 6/6] mpt3sas: store scsi io tracker data in the scsi request Jens Axboe
2015-04-07 17:18   ` Jens Axboe
2015-04-13  9:50 ` [PATCH RFC v2] mpt2/mpt3sas lock reduction for scsi-mq Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150413094719.GC5259@lst.de \
    --to=hch@lst.de \
    --cc=axboe@fb.com \
    --cc=axboe@kernel.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.