All of lore.kernel.org
 help / color / mirror / Atom feed
From: Damien Lespiau <damien.lespiau@intel.com>
To: "Jindal, Sonika" <sonika.jindal@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915/skl: Support for 90/270 rotation
Date: Mon, 13 Apr 2015 12:10:14 +0100	[thread overview]
Message-ID: <20150413111014.GA23484@strange.ger.corp.intel.com> (raw)
In-Reply-To: <552B991A.7060403@intel.com>

On Mon, Apr 13, 2015 at 03:53:22PM +0530, Jindal, Sonika wrote:
> >>I never really got the to understand the need of reversing 90 and 270 :)
> >>The last discussion was not concluded, AFAIR.
> >>Things look correct to me and work fine with the testcase also.
> >>Is there something completely different which I am unable to get?
> >
> >BSpec gives me the impression the hw rotation is cw, whereas the drm one
> >is ccw.
> >
> Yes, HW rotation is cw as per bspec. In drm, where do we consider it as
> anti-cw? I assume it is cw because all the macros work as expected, ie cw.

The DRM is quite a direct implementation of the X semantics:

http://cgit.freedesktop.org/xorg/proto/randrproto/tree/randrproto.txt

"In Randr, the coordinate system is rotated in a counter-clockwise direction
relative to the normal orientation"

This matches the usual orientation of the trigonometric circle.

-- 
Damien
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2015-04-13 11:10 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-10  9:07 [PATCH 1/2] drm/i915/skl: Allow universal planes to position Sonika Jindal
2015-04-10  9:07 ` [PATCH 2/2] drm/i915/skl: Support for 90/270 rotation Sonika Jindal
2015-04-10 14:17   ` Daniel Vetter
2015-04-10 14:44     ` Ville Syrjälä
2015-04-13  4:06       ` Jindal, Sonika
2015-04-13 10:10         ` Ville Syrjälä
2015-04-13 10:23           ` Jindal, Sonika
2015-04-13 10:49             ` Ville Syrjälä
2015-04-13 23:39               ` Matt Roper
2015-04-14 12:19                 ` Jindal, Sonika
2015-04-14 17:27                   ` Daniel Vetter
2015-04-15 10:05                     ` [PATCH 1/2] drm/i915: Swapping 90 and 270 to be compliant with Xrandr Sonika Jindal
2015-04-15 10:05                       ` [PATCH 2/2] Documentation/drm: Update rotation property with 90/270 and description Sonika Jindal
2015-04-15 10:27                         ` Daniel Vetter
2015-04-15 10:29                           ` Jindal, Sonika
2015-04-15 10:42                             ` Daniel Vetter
2015-04-15 10:35                               ` [PATCH] " Sonika Jindal
2015-05-12 12:50                                 ` [Intel-gfx] " Ville Syrjälä
2015-05-13  4:27                                   ` Jindal, Sonika
2015-05-20  6:39                                     ` Jindal, Sonika
2015-05-20  7:49                                     ` Jindal, Sonika
2015-05-20 14:03                                       ` Ville Syrjälä
2015-05-28 11:05                                         ` [PATCH] Documentation/drm: Update rotation property Sonika Jindal
2015-05-28 11:19                                           ` [Intel-gfx] " Daniel Vetter
2015-05-12 12:35                       ` [PATCH 1/2] drm/i915: Swapping 90 and 270 to be compliant with Xrandr Ville Syrjälä
2015-05-20  8:10                         ` [PATCH] " Sonika Jindal
2015-05-20  9:15                           ` Daniel Vetter
2015-04-13 11:10             ` Damien Lespiau [this message]
2015-04-13  4:02     ` [PATCH 2/2] drm/i915/skl: Support for 90/270 rotation Jindal, Sonika
2015-04-14  3:56   ` shuang.he
2015-10-06 13:32 ` [PATCH 1/2] drm/i915/skl: Allow universal planes to position Tvrtko Ursulin
2015-10-06 14:29   ` Matt Roper
2015-10-06 14:42     ` Ville Syrjälä
2015-10-06 15:16       ` Matt Roper
2015-10-06 16:28         ` Ville Syrjälä
2015-10-07 14:19           ` Daniel Vetter
2015-10-08  8:58             ` Tvrtko Ursulin
2015-10-16 12:23               ` Tvrtko Ursulin
  -- strict thread matches above, loose matches on Subject: below --
2015-03-30  8:34 Sonika Jindal
2015-03-30  8:34 ` [PATCH 2/2] drm/i915/skl: Support for 90/270 rotation Sonika Jindal
2015-03-30 12:15   ` shuang.he
2015-04-01 18:22   ` Matt Roper
2015-04-02  4:54     ` Jindal, Sonika
2015-04-02  8:55       ` Tvrtko Ursulin
2015-04-02 15:59       ` Matt Roper
2015-04-06 12:27         ` Jindal, Sonika
2015-04-07  8:13         ` Daniel Vetter
2015-04-07  8:22           ` Jindal, Sonika

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150413111014.GA23484@strange.ger.corp.intel.com \
    --to=damien.lespiau@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=sonika.jindal@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.