From: Jan Kara <jack@suse.cz>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] vfs: Add general support to enforce project quota limits
Date: Mon, 13 Apr 2015 14:19:00 +0200 [thread overview]
Message-ID: <20150413121900.GD3633@quack.suse.cz> (raw)
In-Reply-To: <20150413114851.GP16501@mwanda>
On Mon 13-04-15 14:48:51, Dan Carpenter wrote:
> Ah. Thanks for looking into it. Smatch can't understand bit flags like
> that yet. And it also still doesn't track pointers very well.
> Eventually those things will be improved.
>
> I see now that this out of bounds is also prevented in
> vfs_load_quota_inode(). We don't allow "(type == PRJQUOTA &&
> sb->dq_op->get_projid == NULL)". Since, ->get_projid() is always NULL
> for OCFS2 that means "type" can't equal to PRJQUOTA (2).
>
> Hm.. is ->get_projid set anywhere? Cscope and smatch can't find it if
> it is.
Not yet. There are ext4 patches floating around that will use this.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
prev parent reply other threads:[~2015-04-13 12:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-09 19:39 [Ocfs2-devel] vfs: Add general support to enforce project quota limits Dan Carpenter
2015-04-09 19:46 ` Dan Carpenter
2015-04-13 10:10 ` Jan Kara
2015-04-13 11:48 ` Dan Carpenter
2015-04-13 12:19 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150413121900.GD3633@quack.suse.cz \
--to=jack@suse.cz \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.