From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
Cc: netfilter-devel@vger.kernel.org, kaber@trash.net
Subject: Re: [kernel PATCH] uapi: ebtables: don't include linux/if.h
Date: Mon, 13 Apr 2015 20:10:00 +0200 [thread overview]
Message-ID: <20150413181000.GA3461@salvia> (raw)
In-Reply-To: <20150408175940.GA5358@salvia>
On Wed, Apr 08, 2015 at 07:59:40PM +0200, Pablo Neira Ayuso wrote:
> On Wed, Apr 08, 2015 at 07:41:40PM +0200, Arturo Borrero Gonzalez wrote:
> > From: Pablo Neira Ayuso <pablo@netfilter.org>
> >
> > linux/if.h creates conflicts in userspace with net/if.h
> >
> > By using it here we force userspace to use linux/if.h while
> > net/if.h may be needed.
>
> I'm going to add here that:
>
> include/linux/netfilter_ipv4/ip_tables.h and
> include/linux/netfilter_ipv6/ip6_tables.h
>
> don't include linux/if.h and they also refer to IFNAMSIZ, so they are
> expecting userspace to include use net/if.h from the client program.
Applied, thanks Arturo.
prev parent reply other threads:[~2015-04-13 18:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-08 17:41 [kernel PATCH] uapi: ebtables: don't include linux/if.h Arturo Borrero Gonzalez
2015-04-08 17:59 ` Pablo Neira Ayuso
2015-04-13 18:10 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150413181000.GA3461@salvia \
--to=pablo@netfilter.org \
--cc=arturo.borrero.glez@gmail.com \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.